Skip to content

Comments

NRL-1595 account wide infra deploy pipeline#1098

Merged
anjalitrace2-nhs merged 3 commits intodevelopfrom
NRL-1595-account-wide-infra-deploy
Nov 26, 2025
Merged

NRL-1595 account wide infra deploy pipeline#1098
anjalitrace2-nhs merged 3 commits intodevelopfrom
NRL-1595-account-wide-infra-deploy

Conversation

@anjalitrace2-nhs
Copy link
Contributor

@anjalitrace2-nhs anjalitrace2-nhs commented Nov 21, 2025 •
edited
Loading

Created a github workflow that deployed account-wide infrastructure based on the account-wide deployment readme

  • Created a script to grab a list of environments per account so that we can pull all truststore certs per account with one command.
  • The newly deployed version info is now burned into terraform state, same as the persistent environment deploy
  • Had to trigger with a push rather than a manual run + hardcoded input variables (successful run in dev here). Will test this manual method once merged.
  • Some minor readme updates
  • Had to rebase all my commits to make them verified - squashed for neatness also

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

🚀 PR environment successfully deployed.
Commit Hash: 1449984a048f5704c1e586c8c6ffa5c960a68674
URL: https://nrl1595-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

🚀 PR environment successfully deployed.
Commit Hash: b218e852ff28e59bda41c81ca8a1649396d07a89
URL: https://nrl1595-01ba47.api.record-locator.dev.national.nhs.uk/

@anjalitrace2-nhs anjalitrace2-nhs force-pushed the NRL-1595-account-wide-infra-deploy branch from b218e85 to 21014f9 Compare November 24, 2025 11:11
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

🚀 PR environment successfully deployed.
Commit Hash: 21014f9350890e6cb24343089da7fd19a9094fc5
URL: https://nrl1595-01ba47.api.record-locator.dev.national.nhs.uk/

@atrace @anjalitrace2-nhs
NRL-1595 Create workflow to deploy account-wide infrastructure
c99e926 
- NRL-1595 Minor readme amendments

- NRL-1595 Rough deploy account wide infra workflow

- NRL-1595 Create script to pull truststore certs for all environments in a given account

- NRL-1595 pre-feedback pipeline. Different loop attempts

- NRL-1595 made changes based on feedback and account-specific envs approach. Ready for test runs once workflow envs created

- NRL-1595 pull account id from env secrets rather than variables

- NRL-1595 set trigger to on push to perform first workflow run

- NRL-1595 push only on this branch

- NRL-1595 revert trigger now that we have initial run to manual

- NRL-1595 Fix exit codes

- NRL-1595 Hardcode env choice and branch name for now

- NRL-1595 Attempt to resolve bad account id retrieval

- NRL-1595 Fix tfplan output

- NRL-1595 check deployed version written to state correctly

- NRL-1595 fix bad apply

- NRL-1595 tidy up + remove hardcoded references. This commit's run will fail because no manual inputs. Will need a test running manually once merged into develop but hopefully ready for PR

- NRL-1595 fix bad apply

- NRL-1595 tidy up + remove hardcoded references. This commit's run will fail because no manual inputs. Will need a test running manually once merged into develop but hopefully ready for PR

- NRL-1595 attempt to fix bad apply command

- NRL-1595 Pull target branch and environment from inputs - needs testing once merged

- NRL-1595 Bot suggestions + amendments from self-review
@anjalitrace2-nhs anjalitrace2-nhs force-pushed the NRL-1595-account-wide-infra-deploy branch from ffebbaf to c99e926 Compare November 24, 2025 15:13
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

🚀 PR environment successfully deployed.
Commit Hash: c99e926ae8abf6e9aa49fb72cebb09007ea77c8c
URL: https://nrl1595-01ba47.api.record-locator.dev.national.nhs.uk/

sandyforresternhs
sandyforresternhs reviewed Nov 26, 2025
View reviewed changes
Copy link
Contributor

@sandyforresternhs sandyforresternhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Couple of q's / comments :)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

🚀 PR environment successfully deployed.
Commit Hash: 75991e262eb82cf03a0a553b2339f78b310485c3
URL: https://nrl1595-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Nov 26, 2025

🚀 PR environment successfully deployed.
Commit Hash: f09e1b27afefdff27ee07a75726779b01dfcd368
URL: https://nrl1595-01ba47.api.record-locator.dev.national.nhs.uk/

@anjalitrace2-nhs anjalitrace2-nhs merged commit 3c0c778 into develop Nov 26, 2025
9 checks passed
@anjalitrace2-nhs anjalitrace2-nhs deleted the NRL-1595-account-wide-infra-deploy branch November 26, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandyforresternhs sandyforresternhs sandyforresternhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anjalitrace2-nhs @sandyforresternhs @atrace