NRL-1554 Add new content retrieval mechanism extension by eesa456 · Pull Request #1005 · NHSDigital/NRLF

eesa456 · 2025-08-11T10:14:45Z

No description provided.

github-actions · 2025-08-11T10:21:36Z

🚀 PR environment successfully deployed.
Commit Hash: 37e7375a1e9484ca5d023f433e405b7e6cc97546
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-11T10:33:44Z

🚀 PR environment successfully deployed.
Commit Hash: 2d9deb024e8a8acb686b8ce8332c2d3b689a09ae
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-11T10:42:01Z

🚀 PR environment successfully deployed.
Commit Hash: 5424d1da30cd4d07f4926e3a8b00c53c9ff2639e
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-11T10:51:39Z

🚀 PR environment successfully deployed.
Commit Hash: 317008883d28abc3515927c4104161aa577eed1b
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-08-11T11:04:17Z

🚀 PR environment successfully deployed.
Commit Hash: ef781377da1db99550872a80f00635016b91297f
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-09-05T09:45:00Z

🚀 PR environment successfully deployed.
Commit Hash: 8789b7742288f38fa4582eeb8edee2e31eb6833a
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs

LGTM 💪

Just one comment about some unused parameterized args - rest is bob on.

layer/nrlf/core/tests/test_validators.py

mattdean3-nhs · 2025-09-05T11:42:50Z

layer/nrlf/core/tests/test_validators.py

+    )
+
+
+def test_has_valid_extensions():


loving these 🙌

github-actions · 2025-09-05T13:15:59Z

🚀 PR environment successfully deployed.
Commit Hash: 5ad1a553a7a39906a6f06dc45f0e1a99a993e0ef
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

sonarqubecloud · 2025-09-05T13:27:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-09-05T13:33:20Z

🚀 PR environment successfully deployed.
Commit Hash: 1ffa66a2f295657943e129cc2cb7eb263815b9db
URL: https://nrl1554-ac2cba.api.record-locator.dev.national.nhs.uk/

NRL-1554 Add new content retrieval mechanism extension

4ed5144

eesa456 temporarily deployed to pull-request August 11, 2025 10:14 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:18 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:21 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:23 — with GitHub Actions Inactive

NRL-1554 sonar qube fixes

9fd7818

eesa456 temporarily deployed to pull-request August 11, 2025 10:27 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:31 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request August 11, 2025 10:33 — with GitHub Actions Failure

NRL-1554 reduce complexity

a523b94

eesa456 temporarily deployed to pull-request August 11, 2025 10:35 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:38 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request August 11, 2025 10:42 — with GitHub Actions Failure

NRL-1554 add retrieval mechanism extension to int tests

2790ae2

eesa456 temporarily deployed to pull-request August 11, 2025 10:45 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 10:58 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 11:01 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 11:04 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request August 11, 2025 11:05 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 09:45 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 09:47 — with GitHub Actions Inactive

mattdean3-nhs previously approved these changes Sep 5, 2025

View reviewed changes

NRL-1554 Fix unit test

1ffa66a

axelkrastek1-nhs dismissed mattdean3-nhs’s stale review via 5ad1a55 September 5, 2025 13:09

axelkrastek1-nhs requested a review from a team as a code owner September 5, 2025 13:09

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 13:09 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 13:12 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 13:16 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 13:17 — with GitHub Actions Inactive

axelkrastek1-nhs force-pushed the feature/eema1-NRL-1554-ContentRetrievalMechanismExtension branch from 5ad1a55 to 1ffa66a Compare September 5, 2025 13:27

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 13:27 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 13:30 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 13:33 — with GitHub Actions Inactive

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 13:34 — with GitHub Actions Inactive

axelkrastek1-nhs had a problem deploying to pull-request September 5, 2025 13:34 — with GitHub Actions Failure

axelkrastek1-nhs had a problem deploying to pull-request September 5, 2025 13:45 — with GitHub Actions Failure

axelkrastek1-nhs temporarily deployed to pull-request September 5, 2025 13:50 — with GitHub Actions Inactive

mattdean3-nhs approved these changes Sep 8, 2025

View reviewed changes

axelkrastek1-nhs merged commit 9ab93ae into develop Sep 8, 2025
19 of 21 checks passed

axelkrastek1-nhs deleted the feature/eema1-NRL-1554-ContentRetrievalMechanismExtension branch September 8, 2025 09:02

axelkrastek1-nhs temporarily deployed to pull-request September 8, 2025 09:03 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

NRL-1554 Add new content retrieval mechanism extension#1005

NRL-1554 Add new content retrieval mechanism extension#1005
axelkrastek1-nhs merged 20 commits intodevelopfrom
feature/eema1-NRL-1554-ContentRetrievalMechanismExtension

eesa456 commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

mattdean3-nhs left a comment

Uh oh!

Uh oh!

mattdean3-nhs Sep 5, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

sonarqubecloud bot commented Sep 5, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		)


		def test_has_valid_extensions():

Comments

Conversation

eesa456 commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

mattdean3-nhs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattdean3-nhs Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

sonarqubecloud bot commented Sep 5, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants