Reset time functionality added for state saving/restoring processes (NGWPC 9624)#12
Open
sivasankkar wants to merge 1 commit intodevelopmentfrom
Open
Reset time functionality added for state saving/restoring processes (NGWPC 9624)#12sivasankkar wants to merge 1 commit intodevelopmentfrom
sivasankkar wants to merge 1 commit intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BMI save state implementation currently includes saving and loading the current time of the BMI. This is needed for properly loading state during checkpointing, but that would cause hindcasting loading of states to continually increase, and some BMIs might start looking for data in indexes out of range from the configuration files. An additional SetValue message of "reset_time" is needed to allow the Snow17 BMI to reset its current time to 0 as well as update any other values that create a BMI state equivalent to starting at 0.
Additions
Removals
Changes
reset_timeinsnow17_set_intfunction that calls another subroutine to reset time variables.reset_model_timethat resets time variables.Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other