Skip to content

Comments

Reset time functionality added for state saving/restoring processes (NGWPC 9624)#12

Open
sivasankkar wants to merge 1 commit intodevelopmentfrom
ssn_9624_snow17_reset_time
Open

Reset time functionality added for state saving/restoring processes (NGWPC 9624)#12
sivasankkar wants to merge 1 commit intodevelopmentfrom
ssn_9624_snow17_reset_time

Conversation

@sivasankkar
Copy link

BMI save state implementation currently includes saving and loading the current time of the BMI. This is needed for properly loading state during checkpointing, but that would cause hindcasting loading of states to continually increase, and some BMIs might start looking for data in indexes out of range from the configuration files. An additional SetValue message of "reset_time" is needed to allow the Snow17 BMI to reset its current time to 0 as well as update any other values that create a BMI state equivalent to starting at 0.

Additions

Removals

Changes

  • bmi_snow17.f90: Added a new case for reset_time in snow17_set_int function that calls another subroutine to reset time variables.
  • runSnow17.f90: Added a new function reset_model_time that resets time variables.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant