Create subqueries for geopackage reads (NGWPC-9010 & NGWPC-9018)#82
Draft
idtodd wants to merge 9 commits intodevelopmentfrom
Draft
Create subqueries for geopackage reads (NGWPC-9010 & NGWPC-9018)#82idtodd wants to merge 9 commits intodevelopmentfrom
idtodd wants to merge 9 commits intodevelopmentfrom
Conversation
|
@idtodd I'd like to use this PR for testing regionalization. Can you please do the following and incorporate them into one push to this branch (multiple commits, one push):
Then the GHCR image associated with this PR will be current for testing regionalization. Then before we merge this PR, we just need to revert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlite can restrict the number of binds ("?" in the statement) that it can handle. Turning the single query into a set of subqueries gets around throwing an error when the number of catchments/nexuses gets too large. Prior to version 3.32.0, sqlite's max number of binds is 999, 900 was chosen to keep it well under the limit.
Additions
readfunction.Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support