Skip to content

Comments

Remove attempt to import deprecated ngen_routing module (NGWPC-8286)#42

Merged
cmaynard-ngwpc merged 2 commits intorelease-candidatefrom
cmaynard_NGWPC-8286_fix_no_module_found
Sep 18, 2025
Merged

Remove attempt to import deprecated ngen_routing module (NGWPC-8286)#42
cmaynard-ngwpc merged 2 commits intorelease-candidatefrom
cmaynard_NGWPC-8286_fix_no_module_found

Conversation

@cmaynard-ngwpc
Copy link

@cmaynard-ngwpc cmaynard-ngwpc commented Sep 18, 2025

The newly added code to provide better detail when importing a python module exposed a sequence in the routing code that first tries to import the ngen_routing module, which has been deprecated, then the nwm_routing, which is successful. Per direction of Nels and Bobby at OWP, removed the initial attempt to use ngen_routing and default to importing nwm_routing.

Changes

  • Update LOG message wording.

Removals

  • Removed attempt to import a deprecated module and associated log messages

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@cmaynard-ngwpc cmaynard-ngwpc force-pushed the cmaynard_NGWPC-8286_fix_no_module_found branch from 98a023e to 1b23ce8 Compare September 18, 2025 21:21
@cmaynard-ngwpc cmaynard-ngwpc force-pushed the cmaynard_NGWPC-8286_fix_no_module_found branch from bf5ff7d to 32a3530 Compare September 18, 2025 21:26
@cmaynard-ngwpc cmaynard-ngwpc changed the title Add WARNING and INFO mgs to clarify routing module selection Remove attempt to import deprecated ngen_routing module Sep 18, 2025
@cmaynard-ngwpc cmaynard-ngwpc changed the title Remove attempt to import deprecated ngen_routing module Remove attempt to import deprecated ngen_routing module (NGWPC-8286) Sep 18, 2025
Copy link

@PhilMiller PhilMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine on its own. Any future conflict with Ian's changes to use t-route via BMI should be easy enough to resolve.

@cmaynard-ngwpc cmaynard-ngwpc merged commit 99936ed into release-candidate Sep 18, 2025
12 of 29 checks passed
@cmaynard-ngwpc cmaynard-ngwpc deleted the cmaynard_NGWPC-8286_fix_no_module_found branch September 18, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants