Skip to content

Comments

Remove catchment_id from string construction#38

Closed
cmaynard-ngwpc wants to merge 1 commit intorelease-candidatefrom
cmaynard_correct_catchmentID_in_string_construction
Closed

Remove catchment_id from string construction#38
cmaynard-ngwpc wants to merge 1 commit intorelease-candidatefrom
cmaynard_correct_catchmentID_in_string_construction

Conversation

@cmaynard-ngwpc
Copy link

@cmaynard-ngwpc cmaynard-ngwpc commented Sep 16, 2025

When creating the runtime error message for unit conversion updates in the NetCDFPerFeatureDataProvider, the format from the CSV error message was replicated, but the catchment_id was not available in the scope of this method. There’s not going to be a whole lot of different files, unlike potential different CSV files for different catchments so it is not necessary in this context. Stating NetCDFPerFeatureDataProvider is sufficient for the error message.

Removals

  • Removed catchment_id from the model_name string construction.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@cmaynard-ngwpc
Copy link
Author

Closing this PR and using the updated version of PR 39 instead.

@cmaynard-ngwpc cmaynard-ngwpc deleted the cmaynard_correct_catchmentID_in_string_construction branch September 16, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants