Remove catchment_id from string construction#38
Closed
cmaynard-ngwpc wants to merge 1 commit intorelease-candidatefrom
Closed
Remove catchment_id from string construction#38cmaynard-ngwpc wants to merge 1 commit intorelease-candidatefrom
cmaynard-ngwpc wants to merge 1 commit intorelease-candidatefrom
Conversation
PhilMiller
approved these changes
Sep 16, 2025
Author
|
Closing this PR and using the updated version of PR 39 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating the runtime error message for unit conversion updates in the
NetCDFPerFeatureDataProvider, the format from the CSV error message was replicated, but thecatchment_idwas not available in the scope of this method. There’s not going to be a whole lot of different files, unlike potential different CSV files for different catchments so it is not necessary in this context. StatingNetCDFPerFeatureDataProvideris sufficient for the error message.Removals
catchment_idfrom themodel_namestring construction.Checklist