Improve unit conversion error logging (NGWPC-7604)#35
Merged
cmaynard-ngwpc merged 17 commits intorelease-candidatefrom Sep 16, 2025
Merged
Improve unit conversion error logging (NGWPC-7604)#35cmaynard-ngwpc merged 17 commits intorelease-candidatefrom
cmaynard-ngwpc merged 17 commits intorelease-candidatefrom
Conversation
Author
|
The unit test failure is real - the change as it is right now breaks the tests for |
abe43ad to
30c77ce
Compare
PhilMiller
commented
Sep 15, 2025
…ce data_access to support CSV and NetCDF reporting
…than printing locally
…used in Bmi_Multi_Formulation testing
…rather than printing locally
30c77ce to
b5c8543
Compare
…ic units in tests, and disable now-throwing non-conversion cases
cmaynard-ngwpc
approved these changes
Sep 16, 2025
cmaynard-ngwpc
left a comment
There was a problem hiding this comment.
Reviewed latest commits. Looks good from what I can tell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are failures to convert units between data providers and BMI model consumers, we want to be able to track down the issue quickly and efficiently. We also don't want to be flooded with repetitive warnings about the same failed conversion.
Additions
Changes
Bmi_Module_Formulation::get_value[s]()et al., add information, and rethrow rather than logging hereBmi_Module_Formulation::set_model_inputs_prior_to_update(), check whether that variety of failure has already been reported, and log if it has not.Removals
get_valuewhich is now redundant with logging in the callerTodos
get_values()call path isn't modifiedChecklist