Skip to content

Comments

Merge OWP Master Changes with Development Branch (NGWPC-9797)#150

Merged
idtodd merged 4 commits intodevelopmentfrom
idt-merge-owp-master
Feb 17, 2026
Merged

Merge OWP Master Changes with Development Branch (NGWPC-9797)#150
idtodd merged 4 commits intodevelopmentfrom
idt-merge-owp-master

Conversation

@idtodd
Copy link

@idtodd idtodd commented Feb 12, 2026

Changes made to NGEN in the parent repository need to be integrated into the current development branch of NGWPC's NGEN repository. Most changes could be made automatically with small exceptions like multiple new imports or function definitions having been moved to the .cpp file.

To summarize two major changes coming from OWP:

  1. A system for checking the mass balance of the catchments at each timestep.
  2. Requirements for Boost version 1.86.0.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

Copy link

@cmaynard-ngwpc cmaynard-ngwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested the following formulations

  • CFE-S, Noah-OWP-Modular, T-Route
  • Snow-17, Sac-SMA, Noah-OWP-Modular, T-Route
  • CFE-S, UEB, Noah-OWP-Modular, T-Route
  • TopModel, Noah-OWP-Modular, T-Route
  • LASAM, SMP, SFT, Noah-OWP-Modular, T-Route
  • LSTM, T-Route

@idtodd idtodd merged commit 1452f90 into development Feb 17, 2026
6 of 7 checks passed
@idtodd idtodd deleted the idt-merge-owp-master branch February 17, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants