NetCDF Forcings Provider: Restore ability to read older-format files#110
Open
PhilMiller wants to merge 4 commits intodevelopmentfrom
Open
NetCDF Forcings Provider: Restore ability to read older-format files#110PhilMiller wants to merge 4 commits intodevelopmentfrom
PhilMiller wants to merge 4 commits intodevelopmentfrom
Conversation
… variables with dimensions (catchment, time)
Author
|
I think the revision in 3002d54 addressed the above |
2477cdb to
3002d54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An earlier series of commits addressing NGWPC-1351 added support for the NetCDF files in the format produced by the NextGen Forcing Engine, but dropped support for older NetCDF files (such as the ones provided as samples in this repository):
This PR restores that support.
Changes
Handle each of the following variations between the two formats:
Timevariable with units spanning nanoseconds to hoursTimevariable with (forcing engine) and without (classic) a specified reference epochTimevariable with a single(time)dimension (forcing engine) and(catchment-id, time)dimension (classic)(catchment-id, time)(classic) and(time, catchment-id)(forcing engine)Testing
data/gauge_01073000/forcing.ncTodos
Checklist