Gather and pass routing data to t-route incrementally at each timestep#108
Draft
PhilMiller wants to merge 4 commits intodevelopmentfrom
Draft
Gather and pass routing data to t-route incrementally at each timestep#108PhilMiller wants to merge 4 commits intodevelopmentfrom
PhilMiller wants to merge 4 commits intodevelopmentfrom
Conversation
8c691fa to
1c2d56e
Compare
ee15910 to
d97e4a7
Compare
1c2d56e to
d1a912b
Compare
…omplete class definition
…ows, and call Update() at each timestep
d1a912b to
5d708cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the sake of state saving, we want t-route to be responsible for ownership of all routing state. This avoids a potential need to save the entire history of nexus flows for the duration of the (potentially very long) run in order to pass it to t-route at the very end.
Changes
Testing
Notes
Todos
Checklist