Merged
Conversation
mdeshotel
requested changes
Feb 13, 2026
| """A simple list of partials for common function / method calls.""" | ||
|
|
||
| def __init__(self, mpi_config: MpiConfig, config_options: ConfigOptions): | ||
| a1 = (mpi_config, config_options, err_handler) |
There was a problem hiding this comment.
Can we be more verbose and use args1 args2. Or maybe even args_esmf args_log.
Author
There was a problem hiding this comment.
Updated to args1 and args2, keeping it nameless since each tuple might serve multiple purposes.
| "Unable to create link: " + input_file + " to: " + tmpFile | ||
| ) | ||
| err_handler.log_critical(config_options, mpi_config) | ||
| pt.log_crit(msg=f"Unable to create link: {input_file} to: {tmpFile}") |
There was a problem hiding this comment.
I think we can drop the msg= for these method calls. I think it is pretty clear what we are passing in and I think positionally we are fine. Please double check before making the change.
Author
There was a problem hiding this comment.
Updated to remove the instances of msg=
mdeshotel
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing earlier PR #86 for this one.
This PR includes commits from #98 so it could be merged on its own (larger PR) or after #98 (for smaller diff).
Steps taken for this PR:
Add new Partials class to regrid.py to store partial functions which significantly reduce parameter passing and line count.
Replace existing partials calls with usage of the new Partials class.
Use regex to replace existing log calls with the new Partials calls.
Regex replacements:
Additions
class Partialsin regrid.pyRemovals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support