Closed
Conversation
Ensure files are closed
Forcing engine
Merge release-candidate into development for release 3.1.1.3.0-rc2
…on datasets like MRMS
…on datasets like MRMS
Enables use of RegridOptSuppPcp, which is important for high-resoluti…
Revert inadvertent log calls
…cally adds newline)
Comment out the unused _load_from_cache function
Klarkin aorc cache efficiency
…actor weights workflow
Regridding Weights: unique cache file names, refactor
…_and_conus_tpxo PRVI NWM retrospective forcing file and CONUS TPXO error fixes
…ard_dockerfiles Dockerfiles for hydromt_sfincs and Delft Dashboard
remove lumped forcing from build
Have rank 0 use the reduced any_error value
12 tasks
Author
|
This is created for a wrong merging branch. Recreated a PR at #63. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code use 4 fixed NWM v3 domains, atlgulf, pacific, hawaii and purtorico. Now a subsetting tool that can be used to split these domains into small subdomains is developed. The code of the SCHISM workflow is updated to be able to use any of the subdomains created by the SCHISM domain subsetting tool.
The SCHISM workflow is also divided into two workflows. The first workflow creates all input files for the SCHISM model, and the second workflow runs the SCHSIM model. This is required for consistency between the ways how the SFINCS and SCHSIM simulations are performed.
Additions
-coastal/calib/run_sing_coastal_workflow_pre_schism2.bash
-coastal/calib/sing_schism_forcing.bash
-In the configuration a domain list yaml file is required to specific the model grids and parameters. This is an example of the domain list file
domain:
path: ......\coastalmodels\schism\mesh_a\ # path to base model files
region: hawaii # General region or basin group
epsg: 32604
notes: >
Example SCHISM domain
Removals
Changes
coastal/SFINCS/coastalforcing/main.py
coastal/SFINCS/coastalforcing/process_data/data_processor.py
coastal/calib/initial_discharge.bash
coastal/calib/make_tpxo_ocean.bash
coastal/calib/post_regrid_stofs.bash
coastal/calib/pre_regrid_stofs.bash
coastal/calib/pre_schism.bash
coastal/calib/run_sing_coastal_workflow_make_tpxo_ocean.bash
coastal/calib/run_sing_coastal_workflow_post_schism.bash
coastal/calib/run_sing_coastal_workflow_update_params.bash
coastal/calib/sing_run.bash
coastal/calib/update_param.bash
Testing
1.Tested Hawaii mesh_a domain on the compute nodes. Test passed.
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support