Skip to content

Comments

Enable using split schism domains#62

Closed
zhengtaocui wants to merge 578 commits intomasterfrom
development
Closed

Enable using split schism domains#62
zhengtaocui wants to merge 578 commits intomasterfrom
development

Conversation

@zhengtaocui
Copy link

The original code use 4 fixed NWM v3 domains, atlgulf, pacific, hawaii and purtorico. Now a subsetting tool that can be used to split these domains into small subdomains is developed. The code of the SCHISM workflow is updated to be able to use any of the subdomains created by the SCHISM domain subsetting tool.
The SCHISM workflow is also divided into two workflows. The first workflow creates all input files for the SCHISM model, and the second workflow runs the SCHSIM model. This is required for consistency between the ways how the SFINCS and SCHSIM simulations are performed.

Additions

-coastal/calib/run_sing_coastal_workflow_pre_schism2.bash
-coastal/calib/sing_schism_forcing.bash
-In the configuration a domain list yaml file is required to specific the model grids and parameters. This is an example of the domain list file

domain:

  • name: mesh_a
    path: ......\coastalmodels\schism\mesh_a\ # path to base model files
    region: hawaii # General region or basin group
    epsg: 32604
    notes: >
    Example SCHISM domain

Removals

Changes

coastal/SFINCS/coastalforcing/main.py
coastal/SFINCS/coastalforcing/process_data/data_processor.py
coastal/calib/initial_discharge.bash
coastal/calib/make_tpxo_ocean.bash
coastal/calib/post_regrid_stofs.bash
coastal/calib/pre_regrid_stofs.bash
coastal/calib/pre_schism.bash
coastal/calib/run_sing_coastal_workflow_make_tpxo_ocean.bash
coastal/calib/run_sing_coastal_workflow_post_schism.bash
coastal/calib/run_sing_coastal_workflow_update_params.bash
coastal/calib/sing_run.bash
coastal/calib/update_param.bash

Testing

1.Tested Hawaii mesh_a domain on the compute nodes. Test passed.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

mkarim-rtx and others added 30 commits September 3, 2025 05:55
Ensure files are closed
Merge release-candidate into development for release 3.1.1.3.0-rc2
Enables use of RegridOptSuppPcp, which is important for high-resoluti…
mxkpp and others added 25 commits January 6, 2026 20:27
Comment out the unused _load_from_cache function
Regridding Weights: unique cache file names, refactor
…_and_conus_tpxo

PRVI NWM retrospective forcing file and CONUS TPXO error fixes
…ard_dockerfiles

Dockerfiles for hydromt_sfincs and Delft Dashboard
remove lumped forcing from build
Have rank 0 use the reduced any_error value
@zhengtaocui
Copy link
Author

This is created for a wrong merging branch. Recreated a PR at #63. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.