Skip to content

Comments

Test Remove MPICommExecutor from historical_forcing.py#106

Merged
mxkpp merged 1 commit intodevelopmentfrom
maxkipp-test-remove-mpicommexecutor
Feb 18, 2026
Merged

Test Remove MPICommExecutor from historical_forcing.py#106
mxkpp merged 1 commit intodevelopmentfrom
maxkipp-test-remove-mpicommexecutor

Conversation

@mxkpp
Copy link

@mxkpp mxkpp commented Feb 18, 2026

This removes usage of MPICommExecutor from historical_forcing.py to test behavior on certain environments.

Additions

Removals

  • MPICommExecutor from historical_forcing.py (it is still used in regrid.py).

Changes

Testing

  1. I ran a AORC calibration using the RTE image. Speed with -n 2 on a 4-core Workspace for a 10-day calibration using KGE + DDS was comparable, before and after the change. Effects could differ when running longer simulations with different settings, where more instances of forcing cache file interaction may occur.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

@mxkpp mxkpp requested a review from kyle-larkin February 18, 2026 17:44
@mxkpp
Copy link
Author

mxkpp commented Feb 18, 2026

I edited the description to include a note about before and after performance for a 10-day 2-core AORC calibration ran on a 4-core Workspace.

@kyle-larkin
Copy link

This looks good, and ready to test on integration.

@mxkpp mxkpp merged commit 4252b7f into development Feb 18, 2026
6 checks passed
@mxkpp mxkpp deleted the maxkipp-test-remove-mpicommexecutor branch February 18, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants