Skip to content

Comments

Mdeshotel ngwpc 9713 geo meta linting#105

Draft
mdeshotel wants to merge 8 commits intodevelopmentfrom
mdeshotel_NGWPC-9713_GeoMeta_linting
Draft

Mdeshotel ngwpc 9713 geo meta linting#105
mdeshotel wants to merge 8 commits intodevelopmentfrom
mdeshotel_NGWPC-9713_GeoMeta_linting

Conversation

@mdeshotel
Copy link

@mdeshotel mdeshotel commented Feb 18, 2026

This PR handles 99% of linting issues with Ruff.

Additions

Removals

Changes

-Enforce PEP 8 style guidance for the naming of variables (snake case).
-Raise caught exceptions after logging error message.
-Switch to f-strings for log messages. This was done using the flynt call below.

flynt -tc -ll 9999 ~/ngwpc/ngen-forcing/NextGen_Forcings_Engine_BMI/NextGen_Forcings_Engine/core/regrid.py

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

@mdeshotel mdeshotel marked this pull request as draft February 18, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant