Skip to content

Comments

Merge OWP Master Changes into Development (NGWPC-9802)#8

Merged
idtodd merged 1 commit intodevelopmentfrom
idt-merge-owp-master-9802
Feb 18, 2026
Merged

Merge OWP Master Changes into Development (NGWPC-9802)#8
idtodd merged 1 commit intodevelopmentfrom
idt-merge-owp-master-9802

Conversation

@idtodd
Copy link

@idtodd idtodd commented Feb 12, 2026

Merge into the development branch changes in the master branch of the parent OWP repository. The changes accepted are limited to how loading the config YAML files are handled. Rejected changes were related to how logging was getting called. The logging messages were the exact same between OWP And NGWPC, but OWP's logging didn't use the global LOG object and did not use f-strings for simplifying messages.

Changes

  • yaml.save_load(...) converted to yaml.load(..., Loader=SafeLoader)

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@idtodd idtodd self-assigned this Feb 13, 2026
Copy link

@cmaynard-ngwpc cmaynard-ngwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully ran a formulation and compared results from a previous lstm run. A cursory review of the hydrograph data shows similar, if not the same, results. Compared Permutations for the Metrics, and they were the exact same for each run. Since LSTM is unique in that the calibration manager does not iteratively run LSTM, this is expected.

@idtodd idtodd merged commit 35478b8 into development Feb 18, 2026
8 checks passed
@idtodd idtodd deleted the idt-merge-owp-master-9802 branch February 18, 2026 15:47
@idtodd idtodd restored the idt-merge-owp-master-9802 branch February 20, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants