Merge OWP Master Changes into Development (NGWPC-9802)#8
Merged
idtodd merged 1 commit intodevelopmentfrom Feb 18, 2026
Merged
Conversation
cmaynard-ngwpc
approved these changes
Feb 18, 2026
cmaynard-ngwpc
left a comment
There was a problem hiding this comment.
Successfully ran a formulation and compared results from a previous lstm run. A cursory review of the hydrograph data shows similar, if not the same, results. Compared Permutations for the Metrics, and they were the exact same for each run. Since LSTM is unique in that the calibration manager does not iteratively run LSTM, this is expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge into the development branch changes in the
masterbranch of the parent OWP repository. The changes accepted are limited to how loading the config YAML files are handled. Rejected changes were related to how logging was getting called. The logging messages were the exact same between OWP And NGWPC, but OWP's logging didn't use the globalLOGobject and did not use f-strings for simplifying messages.Changes
yaml.save_load(...)converted toyaml.load(..., Loader=SafeLoader)Checklist
Testing checklist
Target Environment support
Accessibility
Other