Implement Serialization Messaging (NGWPC-9626)#6
Open
idtodd wants to merge 3 commits intodevelopmentfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow for serialization of the BMI data, special variable named used in
get_value_ptrandset_valuecorrespond to the BMI creating, loading, and destroying serialized byte data that stores current state values that are changed when the BMI'supdatemethod is called. Additionally, to facilitate hindcasting, theset_valuemessage"reset_time"will reset the current time of the BMI to zero after loading a state that includes the timestamp.Additions
np.uint8), "serialization_create" (np.uint64), "serializatoin_size" (np.uint64), "serialization_free" (np.intc), and "reset_time" (np.double). These are recognized inget_value_ptrandset_valueas well as methods for determining value types and sizes.lstm_BMIobject.lstm_BMIclass for creating, loading, and freeing properties that update between calls toupdate().StateandEnsembleMemberclasses.Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other