Make the Error Warning and Trapping System a Python Package (NGWPC-9165) #4
Merged
cmaynard-ngwpc merged 4 commits intodevelopmentfrom Jan 8, 2026
Merged
Conversation
f9c36f9 to
1902571
Compare
Add building the lstm_ewts package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Error Warning and Trapping System was embedded in a single file in a subdirectory that required path knowledge in order to import the necessary references. This PR refactors this file into a Python package defined at the codebase top level
srcdirectory making it a cleaner and easier implementation of the logging system. Created unit tests for the new package.Additions
src/lstm_ewtssubdirectory containing thepyproject.tomlfilesrc/lstm_ewts/src/lstm_ewtscontaining the__init__.pyfile defining the public API for the package along with new package module filesconstants.py,paths.py,formatter.py, andconfig.pycontaining the refactoredlogger.pylogging code.test/lstm_ewtsRemovals
logger.pyfile has been deleted.Changes
importstatements in the code base to use the new lstm_ewts package.pip installTesting
Checklist