Express dimensionless units of ice_fraction_xinanjiang and soil_moisture_profile as "1" so UDUNITS2 can parse them (NGWPC-7604)#7
Merged
PhilMiller merged 1 commit intodevelopmentfrom Sep 12, 2025
Conversation
…ure_profile as "1" so UDUNITS2 can parse them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFE presently gives units of its input variables
ice_fraction_xinanjiangandsoil_moisture_profileas the string"none". Both of these are dimensionless fraction quantities. However, the UDUNITS2 library we use to parse units doesn't parse"none"as indicating a dimensionless quantity.Changes
"none"to"1"so that UDUNITS2 understands it as a dimensionless quantity.Checklist