Changed warning msg per OWP request#6
Merged
cmaynard-ngwpc merged 1 commit intorelease-candidatefrom Sep 12, 2025
Merged
Conversation
|
Looks good. |
cmaynard-ngwpc
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the original warning message in cfe.c to the specific message requested by OWP:
WARNING Groundwater flux larger than storage. While this will not cause a run failure, parameter combinations may not be realistic and a mass balance error will occur.Also, per OWP request, commented out the code added a couple of days ago (in conceptaul_reservoir.c) to ensure computed GW flux does not exceed storage.
See additional information in https://jira.nextgenwaterprediction.com/browse/NGWPC-7605