Merge Changes on OWP Mater Branch with Development (NGWPC-9801)

[idtodd]

Merge changes made on the parent NOAA-OWP CFE master branch with the current development branch.

The changes coming in were for freeing data potentially created during BMI initialization and setting data pointers to NULL when the BMI's backing model is created. The frees are being incorporated, but the NULL sets were rejected. Previously in NGWPC, the malloc call had been changed to calloc to ensure all pointers started as NULL, so explicitly setting the pointers to NULL is no longer needed.

Additions

• Additional pointers free'd and set to NULL when Finalize is called on the BMI.

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Visually tested in supported browsers and devices (see checklist below 👇)
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

• Windows
• Linux
• Browser

Accessibility

• Keyboard friendly
• Screen reader friendly

Other

• Is useable without CSS
• Is useable without JS
• Flexible from small to large screens
• No linting errors or warnings
• JavaScript tests are passing

[cmaynard-ngwpc]

Successfully ran a formulation and compared results from a previous cfe run. A cursory review of the hydrograph data shows similar, if not the same, results. Metrics were different during the calibration runs, but that is not a surprise since each run is unique when tuning calibration parameters.