Skip to content

Comments

Get_value Support for "serialization_size" (NGWPC-9616)#14

Merged
idtodd merged 4 commits intodevelopmentfrom
idt-get-value-serialization-size
Jan 27, 2026
Merged

Get_value Support for "serialization_size" (NGWPC-9616)#14
idtodd merged 4 commits intodevelopmentfrom
idt-get-value-serialization-size

Conversation

@idtodd
Copy link

@idtodd idtodd commented Jan 16, 2026

Using Get_value was for "serialization_size" was not configured correctly.

Additions

  • "serialization_size" check on the Get_value function.
  • "reset_time" message in Set_value to set the BMI's time to 0

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@idtodd idtodd requested a review from sivasankkar January 16, 2026 19:44
@idtodd idtodd self-assigned this Jan 16, 2026
Copy link

@sivasankkar sivasankkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are good to be merged.

@idtodd idtodd merged commit f60afb6 into development Jan 27, 2026
@idtodd idtodd deleted the idt-get-value-serialization-size branch January 27, 2026 14:16
@idtodd idtodd changed the title Get_value Support for "serialization_size" Get_value Support for "serialization_size" Jan 27, 2026
@idtodd idtodd changed the title Get_value Support for "serialization_size" Get_value Support for "serialization_size" (NGWPC-9616) Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants