Unit Conversion Error (NGWPC-7604)#10
Merged
cmaynard-ngwpc merged 4 commits intodevelopmentfrom Sep 26, 2025
Merged
Conversation
Express dimensionless units of ice_fraction_xinanjiang and soil_moisture_profile as "1" so UDUNITS2 can parse them
|
Looks good |
cmaynard-ngwpc
previously approved these changes
Sep 23, 2025
cmaynard-ngwpc
left a comment
cmaynard-ngwpc
left a comment
There was a problem hiding this comment.
Based on comments, looks good.
cmaynard-ngwpc
dismissed
their stale review
Need feedback from Mohammed on Phil's comment in Jira.
cmaynard-ngwpc
changed the base branch from
release-candidate
to
development
cmaynard-ngwpc
changed the title
cmaynard-ngwpc
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UDUNITS package can’t parse "none", which caused warnings like “Unable to parse out_units value none.” Normalizing to "1" matches ngen's convention and avoids spurious conversion errors. This ensures variables defined with “no-units” in realization metadata are recorded as dimensionless from the start, preventing downstream unit-conversion attempts and warnings.
Changes
Updated cfe/src/bmi_cfe.c
Testing