Skip to content

[E] Add books to featured; update community main layout#189

Open
1aurend wants to merge 2 commits intomainfrom
ld/books
Open

[E] Add books to featured; update community main layout#189
1aurend wants to merge 2 commits intomainfrom
ld/books

Conversation

@1aurend
Copy link
Contributor

@1aurend 1aurend commented Aug 12, 2025

No description provided.

Copy link
Contributor

@scryptmouse scryptmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would fall back to the books ordering rather than a dynamic ordering here. The dynamic ordering stuff is intended to be used in cases where there isn't a sufficient ordering. It's less efficient than actual orderings.

}
},
{
"path": "book",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have book here but specify featured.books in the template. Are you meaning to select a single book or a group? If a group, rename this to books and use the type entities instead of entity. Otherwise the template needs to be updated.

@1aurend
Copy link
Contributor Author

1aurend commented Aug 18, 2025

I would fall back to the books ordering rather than a dynamic ordering here. The dynamic ordering stuff is intended to be used in cases where there isn't a sufficient ordering. It's less efficient than actual orderings.

It looks like we're falling back to dynamic orderings in a number of places in main layouts. Are there others that should be updated to fall back to the named ordering as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants