Skip to content

Use only log files #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipbl merged 1 commit into from
Nov 14, 2025
Merged

Use only log files #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,24 @@ def cli(verbose):
exit()

logger.remove() # Remove default logger
logger.add(sys.stderr, level=logger_level[verbose]) # Add new logger back

# Start up logger
logger.add(
"logs/sss.log",
rotation="00:00",
retention="1 week",
enqueue=True,
backtrace=True,
diagnose=True,
level=logger_level[verbose],
)

logger.info(" ____")
logger.info(" / . .\\")
logger.info(" \\ ---< Starting SSS")
logger.info(" \\ /")
logger.info(" __________/ /")
logger.info("-=:___________/")
Comment on lines +30 to +38
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the default verbosity level (verbose=0), the logger level is set to "ERROR", which means these INFO level messages (including the ASCII art banner) won't be logged. Users would need to pass -vvv to see INFO messages or -vvvv for DEBUG messages. Consider setting a more appropriate default logging level (e.g., INFO) or documenting this behavior, as many important operational messages throughout the codebase use logger.info() and logger.debug().

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@philipbl philipbl Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback



@cli.command(name="simulator")
Expand Down
16 changes: 0 additions & 16 deletions runners/kiosk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,22 +264,6 @@ def run(simulate, testing=False, new_hardware=False):
logger.debug("Starting physical screen...")
screen = PhysicalScreen()

# Start up logger
logger.add(
"logs/sss.log",
rotation="00:00",
retention="1 week",
enqueue=True,
backtrace=True,
diagnose=True,
)
logger.info(" ____")
logger.info(" / . .\\")
logger.info(" \\ ---< Starting SSS")
logger.info(" \\ /")
logger.info(" __________/ /")
logger.info("-=:___________/")

if testing:
run_loop(screen, user_input_timeout=5, demo_time_override=5)
else:
Expand Down
Loading