fix(benchmarks): handle emulator non-zero exit in run-comparison.sh #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Inferno emulator doesn't exit cleanly after running a dis file, causing run_contestant() to treat all Limbo runs as failures. Fix by checking for valid "Total Time:" output regardless of exit code, and use a 60s timeout for Limbo runs to avoid waiting the full 300s. https://claude.ai/code/session_01JcZKaYV2YTVaZgjsMCW8so
Recompiled .dis files produced by build-linux-amd64.sh using the Linux-native limbo compiler. Also includes bootstrapped mk binary. https://claude.ai/code/session_01JcZKaYV2YTVaZgjsMCW8so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Inferno emulator doesn't exit cleanly after running a dis file,
causing run_contestant() to treat all Limbo runs as failures. Fix by
checking for valid "Total Time:" output regardless of exit code, and
use a 60s timeout for Limbo runs to avoid waiting the full 300s.
https://claude.ai/code/session_01JcZKaYV2YTVaZgjsMCW8so