Skip to content

Conversation

@karlikpj
Copy link
Contributor

@karlikpj karlikpj commented Jan 15, 2026

Closes #2101
Closes #2102

Pull Request Details

Add description

Closes #

Author PR Checklist

Items that the author of the PR is responsible for checking before submitted the PR.

General:

  • I have reviewed the acceptance criteria defined in the ticket and ensured the work has been completed.
  • The commit message passes all quality commit message standards.
  • Unit tests have been updated or created to reflect any javascript changes.
  • Storybook scenarios have been updated or created to reflect any html/css/js changes.

Accessibility:

  • WCAG 2.1 Level AA requirements have been met.

Development:

  • Any new or updated javascript code has 100% unit test coverage.
  • New or updated breakpoints have regression images.
  • Breaking changes have been thoroughly documented in the PR.

Product Reviewer PR Checklist

Items the product team is responsible for reviewing.

General:

  • There are no unexpected or unapproved regression image changes.

  • Functionality of interactive elements meet the acceptance criteria.
  • The product is visually and functionally the same across the different browsers.

Accessibility:

  • AxeDev Tools: there are no new or outstanding accessibility issues introduced in this PR.
  • Lighthouse: scores have not noticeably decreased during this PR.
  • Wave: there are no new errors or contrast errors introduced in this PR.

Design Reviewer PR Checklist

Items the design team is responsible for reviewing. 


General:

  • New or updated features introduced in this PR are developed mobile-first.
  • Breakpoint changes and regression images match those breakpoints.
  • This PR has been tested in all supported browsers at all breakpoints.

Developer Reviewer PR Checklist

Items the development team is responsible for reviewing.

General:

  • New code passes code quality standards set by industry standards.
  • The expected Storybook stories have been added or updated for the new or updated feature.
  • The expected unit tests have been added or updated for the new or updated feature.

Accessibility:

  • VoiceOver: Described content matches with what was expected.
  • Keyboard navigation: new or updated features and content are navigable via the keyboard.

@github-actions
Copy link

2 similar comments
@github-actions
Copy link

@github-actions
Copy link

@karlikpj karlikpj force-pushed the ticket/2101-accordion-doc-site-bug branch 5 times, most recently from 91fba2b to f7c733a Compare January 15, 2026 20:55
@karlikpj karlikpj changed the title (#2101) Accordion Init Bug (#2101, #2102) Accordion Init Bug + 16x9 Images Update Jan 15, 2026
@karlikpj karlikpj force-pushed the ticket/2101-accordion-doc-site-bug branch from f7c733a to 91082be Compare January 15, 2026 20:59
@karlikpj karlikpj marked this pull request as ready for review January 15, 2026 21:39
@karlikpj karlikpj requested a review from a team as a code owner January 15, 2026 21:39
@karlikpj karlikpj force-pushed the ticket/2101-accordion-doc-site-bug branch from 91082be to 325a78a Compare January 16, 2026 20:26
@karlikpj karlikpj force-pushed the ticket/2101-accordion-doc-site-bug branch from 325a78a to 36d9a95 Compare January 20, 2026 15:41
@adrianacastaneda
Copy link

Feature cards on the example site look good! Thanks @karlikpj!

@bennettcc
Copy link

Approved by product and experience on 1/20 - adding the checkmark

@bryanpizzillo bryanpizzillo merged commit f9c6dc3 into develop Jan 26, 2026
6 checks passed
@bryanpizzillo bryanpizzillo deleted the ticket/2101-accordion-doc-site-bug branch January 26, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

6 participants