Draft
Conversation
NCBPFluffyBear
requested changes
Jul 15, 2022
Owner
NCBPFluffyBear
left a comment
NCBPFluffyBear
left a comment
There was a problem hiding this comment.
Some personal preferences, but changes seem functionally sound.
| Files.createDirectory(itemsFolder.toPath()); | ||
| } catch (IOException e) { | ||
| getInstance().getLogger().log(Level.SEVERE, "Failed to create saveditems folder", e); | ||
| getInstance().getLogger().log(Level.WARNING, "Failed to create saveditems folder", e); |
Owner
There was a problem hiding this comment.
I'd like this to be left as severe, if a server owner sees this message I want them to stop the server and fix any file issues
| Material progressItem, int energyProduction, int energyBuffer, | ||
| List<MachineFuel> customRecipes) { | ||
| @ParametersAreNonnullByDefault | ||
| public CustomGenerator(ItemGroup category, |
Owner
There was a problem hiding this comment.
Keep all constructors the way they were (horizontal instead of one param per line)
|
|
||
| } else { | ||
| this.replaceExistingItem(BACK_BUTTON_SLOT, new CustomItemStack(ChestMenuUtils.getBackButton(p, "", ChatColor.GRAY + Slimefun.getLocalization().getMessage(p, "guide.back.guide")))); | ||
| this.replaceExistingItem( |
| SlimeCustomizer.getInstance().getLogger().log(Level.WARNING, "Your generators.yml file still contains" + | ||
| " the example generator! " + | ||
| "Did you forget to set up the plugin?"); | ||
| SlimeCustomizer.getInstance().getLogger().warning( |
Owner
There was a problem hiding this comment.
Keep all messages on one line (I know these exceed the 100 column limit, but I would prefer text to be limited to 1 or 2 lines)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested! I will test as I work on Netheo. Just dropping this now for any immediate feedback, views or if you have optional additions while I am here.