Skip to content

Conversation

@dwfncar
Copy link
Collaborator

@dwfncar dwfncar commented Jan 28, 2026

Prepares the solver infrastructure to support algebraic constraints:

State changes:

  • Add number_of_constraints_ to StateParameters
  • Add constraint_size_ and upper_left_identity_diagonal_ to State
  • Size jacobian for species + constraints

SolverBuilder changes:

  • Add SetConstraintCount() and SetConstraintNames() methods
  • Update Build() to include constraint variables in state

This is backward compatible - when constraint_count_=0 (default), behavior is unchanged from before.

Prepares the solver infrastructure to support algebraic constraints:

State changes:
- Add number_of_constraints_ to StateParameters
- Add constraint_size_ and upper_left_identity_diagonal_ to State
- Size jacobian for species + constraints

SolverBuilder changes:
- Add SetConstraintCount() and SetConstraintNames() methods
- Update Build() to include constraint variables in state

This is backward compatible - when constraint_count_=0 (default),
behavior is unchanged from before.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@dwfncar dwfncar marked this pull request as draft January 28, 2026 18:47
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.20%. Comparing base (aff7fe8) to head (4654f26).
⚠️ Report is 10 commits behind head on dae-1-constraint-classes.

Files with missing lines Patch % Lines
include/micm/solver/solver_builder.inl 33.33% 6 Missing ⚠️
include/micm/solver/state.inl 90.90% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           dae-1-constraint-classes     #906      +/-   ##
============================================================
- Coverage                     94.37%   94.20%   -0.18%     
============================================================
  Files                            69       70       +1     
  Lines                          3380     3432      +52     
============================================================
+ Hits                           3190     3233      +43     
- Misses                          190      199       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants