Add: global LDAP server #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Global Catalog (GC) LDAP server support, which operates on ports 3268 and 3269 (similar to standard LDAP but with limited query support). The changes include new service configurations, test fixtures, and command-line support for launching the global LDAP server.
- Added Global Catalog LDAP server running on ports 3268/3269
- Created dedicated test fixtures and configuration for the global server
- Updated service startup logic to support the new server type
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| traefik.yml | Added entry points for global LDAP ports 3268 and 3269 |
| tests/conftest.py | Added global server test fixtures and event loop configuration |
| interface | Updated subproject commit reference |
| docker-compose.yml | Added global_ldap_server service with Traefik routing configuration |
| app/multidirectory.py | Added global LDAP server factory and command-line argument |
| app/ldap_protocol/server.py | Added debug logging for server initialization |
| app/ioc.py | Added GlobalLDAPServerProvider with LDAP request context support |
| app/config.py | Added global LDAP port configuration and helper methods |
| .package/docker-compose.yml | Removed trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iyashnov
approved these changes
Dec 24, 2025
Naksen
requested changes
Dec 25, 2025
Naksen
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил Global Catalog (GC) - сервер аналогичный LDAP серверу, только на других портах и доступны только некоторые LDAP запросы.
Задача: 1046