Classification environment (Iris dataset) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanott
requested changes
May 1, 2024
| ): | ||
| self._network_settings = network_settings | ||
|
|
||
| self._observation_size = observation_size |
|
|
||
| class ClassificationEnvironment(Environment): | ||
| """ | ||
|
|
Contributor
There was a problem hiding this comment.
We should not need a separate script for classification. Why can't this be run through the existing main script?
Contributor
There was a problem hiding this comment.
New environment needs to be added to the docs
| dataloader_train = DataLoader(self._dataset_train, batch_size=1, shuffle=True) | ||
| dataloader_test = DataLoader(self._dataset_test , batch_size=1, shuffle=False) | ||
| return dataloader_train, dataloader_test | ||
|
|
Contributor
There was a problem hiding this comment.
Should raise for not implemented here
Contributor
There was a problem hiding this comment.
Not sure this is necessary to include, would favor removing it
Co-authored-by: Jordan Ott <jordanott365@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample output: