coreboot-chromeOS #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add google_chromeec_get_kbbacklight() to read the current backlight level. One older boards without feature flags defined, it returns -1 if the device does not have a keyboard backlight. Add google_chromeec_has_kbbacklight() to check if the EC has keyboard backlight capability. The function first tries the EC feature flag (EC_FEATURE_PWM_KEYB), falling back to a read test if unavailable. TEST=tested hooked up to a CFR option to set the keyboard backlight at boot, with visibility controlled by backlight presence, on a range of Chromebooks with and without keyboard backlight support. Change-Id: I74daf7a63f06239d2ba3915221555af494a9340f Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
… boot Change-Id: I92eed62935d0333f548599860b7bbe22f6b9f2b4 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Change-Id: Iff7bd2f1cbd5eae8a6a4d6bbbe3a5e457cbf6f10 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Change-Id: I5444e2e60e93080b1b7931818f51222023fcf450 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
In order to properly read/write only the COREBOOT region using the flashroms's --fmap layout option, the region needs to be aligned on a sector boundary. Most chips support a 4k sector size, so use that for alignment. This eliminates such warnings from flashrom: Region [0x00c54000 - 0x00c541ff] is not sector aligned! Extending end boundaries by 0x00000e00 bytes, from 0x00c541ff -> 0x00c54fff TEST=build/boot google/gladios, update using --fmap and verify no warnings regarding region alignment. Change-Id: Ie4963bbef546aa23364bb9c1c347c5eb5bfeaf8e Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Seems to cause problems and not work properly Change-Id: I2b3acdbc3b53262143b0fd31fa89c81dd612e455 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Owner
|
what's the point of this PR? it doesn't even apply cleanly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
111