EDK2: Add CONFIG_EDK2_RTKUNDI_DRIVER for RTL8168 PXE (Acer CXI4 / Kaisa) #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackadam1981
commented
Feb 1, 2026
jackadam1981
commented
- Kconfig: add EDK2_RTKUNDI_DRIVER, pass -D RTKUNDI_ENABLE=TRUE when enabled - Makefile: add RTKUNDI_ENABLE to BUILD_STR when CONFIG_EDK2_RTKUNDI_DRIVER=y - config.kaisa.uefi: enable CONFIG_EDK2_RTKUNDI_DRIVER for Kaisa (RTL8168 PXE) Co-authored-by: Cursor <cursoragent@cursor.com>
- CONFIG_EC_FOR_CHROMEBOX: on MINIPC hide AC adapter, battery, Chromebook EC Bus, keyboard and vbtn (_STA returns 0) to reduce clutter in device manager - CONFIG_SOC_INTEL_HIDE_EMMC: on MINIPC hide eMMC (ACPI _STA=0 + FSP ScsEmmcEnabled=0) so Windows/Linux show only one SD host controller (TF slot SDXC) - config.kaisa.uefi enables both options Co-authored-by: Cursor <cursoragent@cursor.com>
MrChromebox
reviewed
Feb 2, 2026
| outl(0x8000f0f4, io_base + ERIAR); | ||
| break; | ||
| case 9: | ||
| case 21: |
MrChromebox
reviewed
Feb 2, 2026
| select RT8168_GEN_ACPI_POWER_RESOURCE | ||
| select RT8168_GET_MAC_FROM_VPD | ||
| select RT8168_SET_LED_MODE | ||
| select RT8168_PUT_MAC_TO_ERI |
MrChromebox
reviewed
Feb 2, 2026
| This will enable a workaround in ASL _PS3 and _PS0 methods to force | ||
| SD_PWR_ENABLE to stay low in D3. | ||
|
|
||
| config SOC_INTEL_HIDE_EMMC |
Owner
There was a problem hiding this comment.
this seems like a suboptimal way to hide unused devices. A better way is to detect presence at runtime and set the ACPI _STA accordingly.
is the extra controller in Device Manager really problematic? Most Puff-based Chromeboxes have SKUs with eMMC or NVMe, so you'd have to build this per device.
MrChromebox
reviewed
Feb 2, 2026
| config EC_FOR_CHROMEBOX | ||
| depends on SYSTEM_TYPE_MINIPC | ||
| bool "Hide AC adapter, battery, Chromebook EC Bus and keyboard/vbtn ACPI devices on mini PC" | ||
| default y |
Owner
There was a problem hiding this comment.
default Y means selected unless specifically un-set - we definitely don't want this
MrChromebox
reviewed
Feb 2, 2026
| Enable EDK2's built-in PXE network boot support. This uses EDK2's native | ||
| Simple Network Protocol (SNP) implementation for network booting. | ||
|
|
||
| When enabled, EDK2_LOAD_OPTION_ROMS, EDK2_BOOT_TIMEOUT, EDK2_BOOT_MANAGER_ESCAPE |
Owner
There was a problem hiding this comment.
what do these have do do with network support?
MrChromebox
reviewed
Feb 2, 2026
|
|
||
| config EDK2_CUSTOM_BUILD_PARAMS | ||
| string "edk2 additional custom build parameters" | ||
| default "-D NETWORK_DRIVER_ENABLE=TRUE -D NETWORK_ENABLE=TRUE -D NETWORK_IP4_ENABLE=TRUE -D NETWORK_IP6_ENABLE=FALSE -D NETWORK_PXE_BOOT_ENABLE=TRUE -D NETWORK_HTTP_BOOT_ENABLE=FALSE -D NETWORK_SNP_ENABLE=TRUE -D NETWORK_TLS_ENABLE=FALSE -D NETWORK_ISCSI_ENABLE=FALSE" if EDK2_NETWORK_PXE_SUPPORT |
Owner
There was a problem hiding this comment.
I don't know why you'd set all these here rather than conditionally in the edk2 makefile.
this option is really for ad-hoc testing, not for selectable options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.