Pass object as JSON, not params, to create message POST request#53
Merged
Pass object as JSON, not params, to create message POST request#53
Conversation
The default second argument for [the API connector's POST request](https://github.com/MoveOnOrg/parsons/blob/moveon/parsons/utilities/api_connector.py#L108) is params, the request parameters. We should be passing the message as part of the body of the POST, not as parameters.
technicalex
reviewed
Apr 7, 2025
technicalex
left a comment
technicalex
left a comment
There was a problem hiding this comment.
This looks good to me, but the CI tests are failing. Can you please take a look before I approve? Thank you!
Author
|
The only CI test failing has this error: "Error: Dependency review is not supported on this repository. Please ensure that Dependency graph is enabled along with GitHub Advanced Security on private repositories, see https://github.com/MoveOnOrg/parsons/settings/security_analysis" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default second argument for the API connector's POST request is params, the request parameters. We should be passing the message as part of the body of the POST, not as parameters.