Skip to content

feat: increasing e2e tests with bullmq coverage#997

Open
ytallo wants to merge 62 commits intomainfrom
feature/bullmq-e2e-tests
Open

feat: increasing e2e tests with bullmq coverage#997
ytallo wants to merge 62 commits intomainfrom
feature/bullmq-e2e-tests

Conversation

@ytallo
Copy link
Contributor

@ytallo ytallo commented Dec 2, 2025

Summary

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactor
  • Other (please describe):

Checklist

  • I have read the CONTRIBUTING.md
  • My code follows the code style of this project
  • I have added tests where applicable
  • I have tested my changes locally
  • I have linked relevant issues
  • I have added screenshots for UI changes (if applicable)

Screenshots (if applicable)

Additional Context

ytallo added 30 commits December 1, 2025 14:21
@ytallo
feat(adapter-bullmq-events): add BullMQ event adapter with configurat…
83a1cf4 
…ion options and usage documentation
@ytallo
feat(adapter-bullmq-events): update BullMQ and ioredis dependencies, …
30cfa2b 
…refactor event adapter to use new connection, queue, and worker managers
@ytallo
feat(adapter-bullmq-events): add publishing, tagging, and unpublishin…
4ba6cb5 
…g steps for BullMQ event adapter in workflows
@ytallo
fix(types): make logger and tracer optional in Event type definition
a2fb253
@ytallo
feat(adapter-bullmq-events): update pnpm-lock.yaml with new dependenc…
9727136 
…ies and versions for BullMQ and ioredis
@ytallo
feat(adapter-bullmq-events): implement DLQManager for handling failed…
824288c 
… jobs and add DLQ configuration options
@ytallo
feat: add adapter-redis-cron and update dependencies in pnpm-lock.yaml
998b838
@ytallo
feat(plugin-bullmq): add initial implementation of BullMQ plugin with…
a460c07 
… queue and job management features, including DLQ support and API endpoints
@ytallo
feat(adapter-bullmq-events): refactor BullMQ event adapter to improve…
75d7f05 
… configuration handling, enhance queue and worker management, and streamline error handling in job processing
@ytallo
feat(adapter-bullmq-events): replace subscription ID generation with …
d043d87 
…UUID for improved uniqueness and remove unused method
@ytallo
feat(plugin-bullmq): integrate BullMQ plugin into release workflows a…
c959b40 
…nd configuration, adding publish, unpublish, and tagging steps
@ytallo
fix(tests): add mock Redis client to middleware management tests for …
a59892c 
…improved isolation
@ytallo
chore: update peer dependency for @motiadev/core to allow any version…
5a7431d 
… >=0.8.0 across multiple adapters
@ytallo
feat(plugin-bullmq): refactor queue and job management by introducing…
15abf21 
… streams for better performance and event handling
@ytallo
feat(plugin-bullmq): refactor job and queue handling by replacing use…
34acc41 
…Jobs hook with dedicated mutations and queries for improved performance and clarity
@ytallo
feat: integrate BullMQ plugin into various configuration templates an…
d98b446 
…d update RedisMemoryManager error handling
@ytallo
refactor(trace-timeline): simplify data fetching by replacing useStre…
bca4112 
…amItem with useStreamGroup for improved performance
@ytallo
feat(tests): enhance basic tutorial test by clearing closed tutorial …
3dddbc8 
…state from localStorage
@ytallo
testing
4a4c6f4
@ytallo
feat: add @motiadev/plugin-bullmq to deployment workflow and update g…
62c5b61 
…lobal setup to include new dependencies
@ytallo
refactor(global-setup): remove unused stdio options and optimize pnpm…
dea6adc 
… install command for specific project
@ytallo
chore(global-setup): add console log for packageJson to assist with d…
e3daef9 
…ebugging
@ytallo
chore(global-setup): add zod dependency to package.json for validation
bf8e05d
@ytallo
chore(global-setup): update stdio options for execSync commands to in…
b2d6889 
…herit from parent process
@ytallo
chore(global-setup): modify pnpm install command to target specific p…
56e05ab 
…roject path
@ytallo
refactor(global-setup): switch from exec to spawn for server process …
9e295c9 
…and enhance logging
@ytallo
fix(global-setup): move serverProcess.unref() to ensure proper server…
f8c1263 
… readiness before proceeding
@ytallo
feat(e2e-tests): add Redis installation step to end-to-end test workf…
2dab01b 
…low for improved testing environment
@ytallo
refactor(global-setup): simplify server process handling and improve …
e22eb79 
…logging
@ytallo
feat(bullmq): implement BullMQ event handling and testing framework w…
f845214 
…ith multiple queue configurations and retry mechanisms
ytallo added 13 commits December 1, 2025 22:31
@ytallo
refactor(trace-timeline): simplify data fetching by replacing useStre…
639b582 
…amItem with useStreamGroup for improved performance
@ytallo
feat(tests): enhance basic tutorial test by clearing closed tutorial …
f56c02f 
…state from localStorage
@ytallo
testing
6c76b31
@ytallo
feat: add @motiadev/plugin-bullmq to deployment workflow and update g…
4cb12fc 
…lobal setup to include new dependencies
@ytallo
refactor(global-setup): remove unused stdio options and optimize pnpm…
c3dbe06 
… install command for specific project
@ytallo
chore(global-setup): add console log for packageJson to assist with d…
8302d86 
…ebugging
@ytallo
chore(global-setup): add zod dependency to package.json for validation
1bada66
@ytallo
chore(global-setup): update stdio options for execSync commands to in…
365b641 
…herit from parent process
@ytallo
chore(global-setup): modify pnpm install command to target specific p…
ddcaab8 
…roject path
@ytallo
refactor(global-setup): switch from exec to spawn for server process …
0a62a9f 
…and enhance logging
@ytallo
fix(global-setup): move serverProcess.unref() to ensure proper server…
627973a 
… readiness before proceeding
@ytallo
feat(e2e-tests): add Redis installation step to end-to-end test workf…
f9dba44 
…low for improved testing environment
@ytallo
refactor(global-setup): simplify server process handling and improve …
33a9212 
…logging
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

📦 This PR is large (>500 lines). Please ensure it has been properly tested.

@ytallo ytallo force-pushed the feature/bullmq-events-adapter branch from e22eb79 to 33a9212 Compare December 2, 2025 01:31
@ytallo ytallo changed the base branch from feature/bullmq-events-adapter to main December 2, 2025 01:47
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 2, 2025
View reviewed changes
packages/e2e/tests/bullmq/adapter/retry-and-dlq.spec.ts
import type { ApiHelpers } from '@/src/page-objects/ApiHelpers'

const RETRY_QUEUE = 'bullmq.tests.retry.BullMQRetryConsumer'
const DLQ_QUEUE = `${RETRY_QUEUE}.dlq`

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable DLQ_QUEUE.

Copilot Autofix

AI 2 months ago

To fix the problem, we should remove the declaration of the unused variable DLQ_QUEUE from the file packages/e2e/tests/bullmq/adapter/retry-and-dlq.spec.ts. Only the line(s) that declare DLQ_QUEUE should be removed. This edit is limited to the definition itself (line 11), and no further edits are needed since the variable is not referenced anywhere in the provided code.

Suggested changeset 1
packages/e2e/tests/bullmq/adapter/retry-and-dlq.spec.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/e2e/tests/bullmq/adapter/retry-and-dlq.spec.ts b/packages/e2e/tests/bullmq/adapter/retry-and-dlq.spec.ts
--- a/packages/e2e/tests/bullmq/adapter/retry-and-dlq.spec.ts
+++ b/packages/e2e/tests/bullmq/adapter/retry-and-dlq.spec.ts
@@ -8,7 +8,6 @@
 import type { ApiHelpers } from '@/src/page-objects/ApiHelpers'
 
 const RETRY_QUEUE = 'bullmq.tests.retry.BullMQRetryConsumer'
-const DLQ_QUEUE = `${RETRY_QUEUE}.dlq`
 
 const waitForDlqJob = async (api: ApiHelpers, testCaseId: string) => {
   const timeoutMs = 20000
EOF
@@ -8,7 +8,6 @@
import type { ApiHelpers } from '@/src/page-objects/ApiHelpers'

const RETRY_QUEUE = 'bullmq.tests.retry.BullMQRetryConsumer'
const DLQ_QUEUE = `${RETRY_QUEUE}.dlq`

const waitForDlqJob = async (api: ApiHelpers, testCaseId: string) => {
const timeoutMs = 20000
Copilot is powered by AI and may make mistakes. Always verify output.
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

E2E Test Results ✅

All tests have completed. Tests passed.

Matrix: 2 OS (Ubuntu, macOS) × 2 Templates (TypeScript, Python) = 4 jobs

View detailed test results

This comment is automatically posted by the PR E2E Results workflow.

@ytallo ytallo changed the title Feature/bullmq e2e tests feat: increasing e2e tests with bullmq coverage Dec 2, 2025
@github-actions
Copy link

github-actions bot commented Feb 1, 2026

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed if no further activity occurs within 14 days.
If you're still working on this, please leave a comment or push new commits.
Thank you for your contributions to Motia! 🚀

@github-actions github-actions bot added the stale label Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/L size/XL stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ytallo