script: Fix morse_setup compatible to run in symbolic link #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In linux, $(pwd) only read the "current working directory path" instead of "absolute path",and this is a bit tricky when the path is from a symbolic link. For example, we got a openwrt repo at path "/mnt/ssd_500gb/github/openwrt" If using "ln -s /mnt/ssd_500gb/github/openwrt ~/openwrt" to link into home directory, in path "~/openwrt," the following command will show: git rev-parse --show-toplevel -> /mnt/ssd_500gb/github/openwrt echo $(pwd) -> /home/elwin/openwrt echo $(readlink -f $(pwd)) -> /mnt/ssd_500gb/github/openwrt Fix this issue to read the realpath of pwd so that when running in a link, morse_setup will find the correct path. Signed-off-by: Elwin Huang <s09289728096@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In linux, $(pwd) only read the "current working directory path" instead of "absolute path", and this is a bit tricky when the path is from a symbolic link.
For example, we got a openwrt repo at path "/mnt/ssd_500gb/github/openwrt"
If using
ln -s /mnt/ssd_500gb/github/openwrt ~/openwrtto link into home directory, in path~/openwrt, the following command will show:Fix this issue to read the realpath of pwd so that when running in a link, morse_setup will find the correct path.