-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Add ability to write patching results to JSON file #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a266262
feat: Add ability to write patching results to JSON file
wchill fd5af79
chore: Handle primitive types explicitly
wchill 838f7da
chore: Add package information and status of individual steps to resu…
wchill 4f7f5e5
chore: Simplify addStepResult
wchill ff80fe8
Apply suggestions from code review
wchill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,20 @@ | ||
| [versions] | ||
| shadow = "8.3.9" | ||
| kotlin = "2.0.21" | ||
| kotlinx = "1.8.1" | ||
| kotlin = "2.3.0" | ||
| kotlinx = "1.9.0" | ||
| picocli = "4.7.7" | ||
| morphe-patcher = "1.0.1" | ||
| morphe-library = "1.0.1" | ||
|
|
||
| [libraries] | ||
| kotlin-test = { module = "org.jetbrains.kotlin:kotlin-test", version.ref = "kotlin" } | ||
| kotlinx-coroutines-core = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-core", version.ref = "kotlinx" } | ||
| kotlinx-serialization-json = { module = "org.jetbrains.kotlinx:kotlinx-serialization-json", version.ref = "kotlinx" } | ||
| picocli = { module = "info.picocli:picocli", version.ref = "picocli" } | ||
| morphe-patcher = { module = "app.morphe:morphe-patcher", version.ref = "morphe-patcher" } | ||
| morphe-library = { module = "app.morphe:morphe-library-jvm", version.ref = "morphe-library" } | ||
|
|
||
| [plugins] | ||
| shadow = { id = "com.gradleup.shadow", version.ref = "shadow" } | ||
| kotlin = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" } | ||
| kotlin-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/main/kotlin/app/morphe/cli/command/model/FailedPatch.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package app.morphe.cli.command.model | ||
|
|
||
| import kotlinx.serialization.ExperimentalSerializationApi | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @ExperimentalSerializationApi | ||
| @Serializable | ||
| data class FailedPatch( | ||
| val patch: SerializablePatch, | ||
| val reason: String | ||
| ) |
43 changes: 43 additions & 0 deletions
43
src/main/kotlin/app/morphe/cli/command/model/PatchingResult.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package app.morphe.cli.command.model | ||
|
|
||
| import kotlinx.serialization.EncodeDefault | ||
| import kotlinx.serialization.ExperimentalSerializationApi | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @ExperimentalSerializationApi | ||
| @Serializable | ||
| data class PatchingResult( | ||
| var packageName: String? = null, | ||
| var packageVersion: String? = null, | ||
| var success: Boolean = true, | ||
| @EncodeDefault val patchingSteps: MutableList<PatchingStepResult> = mutableListOf(), | ||
| @EncodeDefault val appliedPatches: MutableList<SerializablePatch> = mutableListOf(), | ||
| @EncodeDefault val failedPatches: MutableList<FailedPatch> = mutableListOf() | ||
| ) | ||
|
|
||
| @ExperimentalSerializationApi | ||
| fun <R> PatchingResult.addStepResult( | ||
| step: PatchingStep, | ||
| block: () -> R, | ||
| ): R { | ||
| try { | ||
| val result = block() | ||
| this.patchingSteps.add( | ||
| PatchingStepResult( | ||
| step = step, | ||
| success = true | ||
| ) | ||
| ) | ||
| return result | ||
| } catch (e: Exception) { | ||
| this.success = false | ||
| this.patchingSteps.add( | ||
| PatchingStepResult( | ||
| step = step, | ||
| success = false, | ||
| message = e.toString() | ||
| ) | ||
| ) | ||
| throw e | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package app.morphe.cli.command.model | ||
|
|
||
| enum class PatchingStep { | ||
| PATCHING, | ||
| REBUILDING, | ||
| SIGNING, | ||
| INSTALLING | ||
| } |
12 changes: 12 additions & 0 deletions
12
src/main/kotlin/app/morphe/cli/command/model/PatchingStepResult.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package app.morphe.cli.command.model | ||
|
|
||
| import kotlinx.serialization.ExperimentalSerializationApi | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @ExperimentalSerializationApi | ||
| @Serializable | ||
| data class PatchingStepResult( | ||
| val step: PatchingStep, | ||
| val success: Boolean, | ||
| val message: String? = null | ||
| ) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.