Project/Draw: Implement GpuMemAllocator
#584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonsterDruide1
force-pushed
the
GpuMemAllocator
branch
from
143540b to
2b52121
Compare
Owner
Author
|
Ready for review. |
Contributor
fruityloops1
left a comment
fruityloops1
left a comment
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)
lib/al/Project/Draw/GpuMemAllocator.h line 23 at r1 (raw file):
~GpuMemAllocator(); void createMemory(const char*, s32, sead::Heap*, s32, agl::MemoryAttribute);
Param names?
MonsterDruide1
commented
May 20, 2025
Owner
Author
MonsterDruide1
left a comment
MonsterDruide1
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @fruityloops1 and @MonsterDruide1)
lib/al/Project/Draw/GpuMemAllocator.h line 23 at r1 (raw file):
Previously, fruityloops1 (Fruityloops) wrote…
Param names?
Done.
Contributor
fruityloops1
left a comment
fruityloops1
left a comment
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MonsterDruide1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unfinished header by @fruityloops1 resulted in me looking into the remaining part of this class - implementing it on the way.
Two mismatches can currently be observed:1) https://decomp.me/scratch/QhCcn - withinGPUMemBlockT's destructor. It was probably wrong before, and is now being exposed because the function is generated for the first time.2) https://decomp.me/scratch/nhsZ0 -al::GpuMemAllocator::allocMemoryshows some slightly different codegen on anifwith arithmetic.All mismatches have been fixed by @german77 and me!
Blocked by open-ead/agl#18This change is