fix(GoogleLogin): guarantee credential presence onSuccess#383
Open
zetlen wants to merge 1 commit intoMomenSherif:masterfrom
Open
fix(GoogleLogin): guarantee credential presence onSuccess#383zetlen wants to merge 1 commit intoMomenSherif:masterfrom
zetlen wants to merge 1 commit intoMomenSherif:masterfrom
Conversation
🦋 Changeset detectedLatest commit: f0cec05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
445f663 to
62aa33c
Compare
Author
|
Not sure why the deployment is failing, let me know what I can do! |
|
sorry for not be helpfull to solve this problem, but I actually need this fix . mabe try to build a new pr :D |
62aa33c to
f0cec05
Compare
|
@zetlen-dandy is attempting to deploy a commit to the momensherif's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a type assertion to the signature of
onSuccessof theGoogleLogincomponent to reflect that thecredentialResponse.credentialwill always be present if the handler is called.The callback handler in the
GoogleLogincomponent checks that thecredentialResponse.credentialis truthy, so it can't be the empty string when passed to onSuccess:Since the code guarantees this, the
onSuccesshandler shouldn't have to assert that the credential is present again. This PR adjusts the type of the parameter toonSuccessso that thecredentialproperty is always truthy.