Skip to content

Adapt for Nextflow 25.10.2#68

Merged
matrulda merged 4 commits intoMolmed:mainfrom
matrulda:nextflow_25.10.2
Jan 21, 2026
Merged

Adapt for Nextflow 25.10.2#68
matrulda merged 4 commits intoMolmed:mainfrom
matrulda:nextflow_25.10.2

Conversation

@matrulda
Copy link
Collaborator

Description
This PR makes sure that the pipeline is written in strict mode, which was enforced from Nextflow 25.10.
In addition to that:

  • References and instructions for running tests locally have been updated
  • Pull request template has been updated to a simpler one

Risk analysis
Very small change and tests are passing, no risks identified.

Validation procedure
Run pipeline on Miarka via the sequencing report service.

Copy link
Contributor

@nkongenelly nkongenelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I am assuming that the strict mode is it the default for nextflow v 25.10 or does it have to be passed in the nextflow command e.g from the arteria-sequencing-service that creates the nextflow command?

@matrulda
Copy link
Collaborator Author

Thanks for the review! 🙏

Looks good. I am assuming that the strict mode is it the default for nextflow v 25.10 or does it have to be passed in the nextflow command e.g from the arteria-sequencing-service that creates the nextflow command?

Strict mode in this context means that the nextflow pipeline syntax need to follow a specific format. It is enforced. Like python2 allowing print $var, while python3 enforces print($var). So we need to make sure that all nextflow pipelines we run uses format. The easiest way to do this is to test them with nextflow 25.10.+. Did this answer your question or did I misunderstand?

@nkongenelly
Copy link
Contributor

Thanks for the review! 🙏

Looks good. I am assuming that the strict mode is it the default for nextflow v 25.10 or does it have to be passed in the nextflow command e.g from the arteria-sequencing-service that creates the nextflow command?

Strict mode in this context means that the nextflow pipeline syntax need to follow a specific format. It is enforced. Like python2 allowing print $var, while python3 enforces print($var). So we need to make sure that all nextflow pipelines we run uses format. The easiest way to do this is to test them with nextflow 25.10.+. Did this answer your question or did I misunderstand?

Oh perfect! Yes this answers my question. Thank you.

@matrulda matrulda merged commit bcb064b into Molmed:main Jan 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants