feat: adding option to pass channel type to socket#1174
Draft
James-Frowen wants to merge 10 commits intomainfrom
Draft
feat: adding option to pass channel type to socket#1174James-Frowen wants to merge 10 commits intomainfrom
James-Frowen wants to merge 10 commits intomainfrom
Conversation
SocketFactory are now required to give more information about the socket they are creating BREAKING CHANGE: abstract MaxPacketSize property replaced with SocketInfo
BREAKING CHANGE: ISocket.Send now requires SendMode argument
useful when using steam or epic relay and you want to use their reliability Mirage work decide which connection type to use based on the values in SocketInfo. It will then use SendMode to tell the socket which channel it should usee for a message BREAKING CHANGE: Peer now SocketInfo to be passed in
BREAKING CHANGE: config.DisableReliableLayer removed. value is inferred from SocketInfo instead
batched message have a 2 byte length, but if socket's max size is bigger than that they could not be send. Now ArrayBatch will treat length 0 as not batched and just send the whole message to high level
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
James-Frowen
added
keep-open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useful when using steam or epic relay and you want to use their reliability
Mirage work decide which connection type to use based on the values in SocketInfo. It will then use SendMode to tell the socket which channel it should usee for a message