GEOPY-2619: Joint surveys fails validation if no starting/reference models chosen #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/ga-4.7 #325 +/- ##
==================================================
+ Coverage 91.15% 91.44% +0.28%
==================================================
Files 114 114
Lines 6205 6216 +11
Branches 760 760
==================================================
+ Hits 5656 5684 +28
+ Misses 347 339 -8
+ Partials 202 193 -9
🚀 New features to boost your workflow:
|
MatthieuCMira
previously approved these changes
Dec 3, 2025
Contributor
MatthieuCMira
left a comment
MatthieuCMira
left a comment
There was a problem hiding this comment.
Seems ok, just this import is strange
sebhmg
reviewed
Dec 4, 2025
# Conflicts: # simpeg_drivers/components/factories/directives_factory.py # simpeg_drivers/components/models.py
# Conflicts: # simpeg_drivers/joint/joint_surveys/options.py
…r.lower()" This reverts commit b6b450c. # Conflicts: # simpeg_drivers/components/factories/directives_factory.py # simpeg_drivers/components/factories/source_factory.py # simpeg_drivers/components/models.py # simpeg_drivers/joint/driver.py # simpeg_drivers/joint/joint_surveys/driver.py # simpeg_drivers/options.py # simpeg_drivers/plate_simulation/driver.py
This reverts commit da7d1a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOPY-2619 - Joint surveys fails validation if no starting/reference models chosen