DEVOPS-922: build a Python environment for Analyst 4.7 development #111
Conversation
github-actions
bot
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Python build environment configuration for Analyst 4.7 development by modifying package dependency versions and improving the build recipe structure.
Key Changes
- Updated dependency versions including geoh5py (0.12.0b3 → 0.12.0b5), coverage (7.11.0 → 7.12.0), and pytest (8.4.2 → 9.0.1)
- Introduced a
module_namevariable in recipe.yaml for better parameterization - Added package content verification tests and THIRD_PARTY_SOFTWARE.rst to license files
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| recipe.yaml | Updated dependency version constraints, added module_name variable for test imports, included package content verification, and added third-party software license file |
| pyproject.toml | Updated geoh5py minimum version from 0.12.0b1 to 0.12.0b5 |
| poetry.lock | Automatic lock file update reflecting dependency version changes including Poetry 2.1.4→2.2.1, astroid, certifi, coverage, geoh5py, pydantic/pydantic-core, and pytest |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - python >=${{ python_min }} | ||
| # Mira packages | ||
| - geoh5py >=0.12.0a, <0.13.dev | ||
| - geoh5py >=0.12.0b5, 0.12.* |
There was a problem hiding this comment.
The version constraint syntax >=0.12.0b5, 0.12.* is incorrect. The comma should be followed by a comparison operator. It should be either >=0.12.0b5,<0.13.dev (matching the pattern in pyproject.toml) or >=0.12.0b5,<0.13.0 for proper version constraint syntax.
| - geoh5py >=0.12.0b5, 0.12.* | |
| - geoh5py >=0.12.0b5,<0.13.0 |
| - properties 0.6.* | ||
| - pypng 0.20220715.* | ||
| - six >=1.16.0, <2.0.dev | ||
| - six >=1.16.0, 1.* |
There was a problem hiding this comment.
The version constraint syntax >=1.16.0, 1.* is incorrect. The comma should be followed by a comparison operator. It should be >=1.16.0,<2.0 or >=1.16.0,<2.0.dev to properly specify the upper bound.
| - six >=1.16.0, 1.* | |
| - six >=1.16.0,<2.0 |
| - python 3.10.* | ||
| - poetry-core >=1.8.0 | ||
| - poetry-dynamic-versioning >=1.9, <2.0.dev | ||
| - poetry-dynamic-versioning >=1.9, 1.* |
There was a problem hiding this comment.
The version constraint syntax >=1.9, 1.* is incorrect. It should use <2.0 instead of 1.* as the upper bound, or use >=1.9,<2.0.dev to match the pattern used in other dependencies. The comma-separated format requires proper comparison operators.
| - poetry-dynamic-versioning >=1.9, 1.* | |
| - poetry-dynamic-versioning >=1.9,<2.0.dev |
DEVOPS-922 - build a Python environment for Analyst 4.7 development