-
Notifications
You must be signed in to change notification settings - Fork 0
DEVOPS-693: pixi all the way, including for doc #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
- fix test for remove the jinja dependency - pixi task for build the doc, used in RTD - tweak RTD configuration - replace install_in_analyst bat by pixi task - use pixi to run pylint from pre-commit
|
doc is building but has warnings (I set the flag to report them as errors...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the project from conda-lock to pixi for dependency management. It removes jinja2 dependency from tests, configures pixi environments, and adds new documentation build tasks.
- Removes all conda-lock files and replaces dependency management with pixi configuration
- Removes jinja2 templating from test files and simplifies recipe version reading
- Updates CI/CD workflows and documentation configuration to use pixi
Reviewed Changes
Copilot reviewed 29 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/version_test.py | Removes jinja2 dependency and simplifies recipe.yaml parsing |
| pyproject.toml | Moves dependencies from poetry to standard project section and updates keywords |
| pixi.toml | Adds comprehensive pixi configuration with environments and tasks |
| install_in_analyst.bat | Removes conda-based installation script |
| .readthedocs.yml | Updates RTD config to use pixi for documentation builds |
| .github/workflows/python_analysis.yml | Updates CI workflows to use pixi package manager |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "geoapps-utils >= 0.6.0a, == 0.6.*", | ||
| "geoh5py >= 0.12.0a1, == 0.12.*", | ||
| # other direct dependencies | ||
| "discretize == 0.11.*", | ||
| "numpy == 1.26.*", | ||
| "pydantic >= 2.5.2, == 2.*", |
Copilot
AI
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency specification combines both minimum version and exact version constraints (e.g., >= 0.6.0a, == 0.6.*). This pattern is redundant since the exact version constraint already implies the minimum. Consider using only the exact version constraint format.
| "geoapps-utils >= 0.6.0a, == 0.6.*", | |
| "geoh5py >= 0.12.0a1, == 0.12.*", | |
| # other direct dependencies | |
| "discretize == 0.11.*", | |
| "numpy == 1.26.*", | |
| "pydantic >= 2.5.2, == 2.*", | |
| "geoapps-utils == 0.6.*", | |
| "geoh5py == 0.12.*", | |
| # other direct dependencies | |
| "discretize == 0.11.*", | |
| "numpy == 1.26.*", | |
| "pydantic == 2.*", |
| cmd = "sphinx-build -T -nW -b {{builder}} docs/source {{outputdir}}/{{builder}}" | ||
|
|
||
| [tasks.show-pip-source] | ||
| args = [{ arg = "packages", "default" = "geoh5py geoapps-utils" }] |
Copilot
AI
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key "default" should be default without quotes for consistency with other argument definitions in the file.
| args = [{ arg = "packages", "default" = "geoh5py geoapps-utils" }] | |
| args = [{ arg = "packages", default = "geoh5py geoapps-utils" }] |
DEVOPS-693 - migrate from conda-lock to pixi