Skip to content

Conversation

@sebhmg
Copy link
Contributor

@sebhmg sebhmg commented Sep 16, 2025

DEVOPS-693 - migrate from conda-lock to pixi

  • fix test for remove the jinja dependency
  • pixi task for build the doc, used in RTD
  • tweak RTD configuration
  • replace install_in_analyst bat by pixi task

@github-actions github-actions bot changed the title [DEVOPS-693] pixi all the way, including for doc DEVOPS-693: pixi all the way, including for doc Sep 16, 2025
- fix test for remove the jinja dependency
- pixi task for build the doc, used in RTD
- tweak RTD configuration
- replace install_in_analyst bat by pixi task
- use pixi to run pylint from pre-commit
@sebhmg
Copy link
Contributor Author

sebhmg commented Sep 16, 2025

doc is building but has warnings (I set the flag to report them as errors...)
See https://app.readthedocs.com/projects/mirageoscience-grid-apps/builds/3362588/

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project from conda-lock to pixi for dependency management. It removes jinja2 dependency from tests, configures pixi environments, and adds new documentation build tasks.

  • Removes all conda-lock files and replaces dependency management with pixi configuration
  • Removes jinja2 templating from test files and simplifies recipe version reading
  • Updates CI/CD workflows and documentation configuration to use pixi

Reviewed Changes

Copilot reviewed 29 out of 34 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/version_test.py Removes jinja2 dependency and simplifies recipe.yaml parsing
pyproject.toml Moves dependencies from poetry to standard project section and updates keywords
pixi.toml Adds comprehensive pixi configuration with environments and tasks
install_in_analyst.bat Removes conda-based installation script
.readthedocs.yml Updates RTD config to use pixi for documentation builds
.github/workflows/python_analysis.yml Updates CI workflows to use pixi package manager

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +38 to +43
"geoapps-utils >= 0.6.0a, == 0.6.*",
"geoh5py >= 0.12.0a1, == 0.12.*",
# other direct dependencies
"discretize == 0.11.*",
"numpy == 1.26.*",
"pydantic >= 2.5.2, == 2.*",
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency specification combines both minimum version and exact version constraints (e.g., >= 0.6.0a, == 0.6.*). This pattern is redundant since the exact version constraint already implies the minimum. Consider using only the exact version constraint format.

Suggested change
"geoapps-utils >= 0.6.0a, == 0.6.*",
"geoh5py >= 0.12.0a1, == 0.12.*",
# other direct dependencies
"discretize == 0.11.*",
"numpy == 1.26.*",
"pydantic >= 2.5.2, == 2.*",
"geoapps-utils == 0.6.*",
"geoh5py == 0.12.*",
# other direct dependencies
"discretize == 0.11.*",
"numpy == 1.26.*",
"pydantic == 2.*",

Copilot uses AI. Check for mistakes.
cmd = "sphinx-build -T -nW -b {{builder}} docs/source {{outputdir}}/{{builder}}"

[tasks.show-pip-source]
args = [{ arg = "packages", "default" = "geoh5py geoapps-utils" }]
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key "default" should be default without quotes for consistency with other argument definitions in the file.

Suggested change
args = [{ arg = "packages", "default" = "geoh5py geoapps-utils" }]
args = [{ arg = "packages", default = "geoh5py geoapps-utils" }]

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants