Implemented Trim of empty spaces of queryString search#58
Draft
PetarNeshkov wants to merge 2 commits intoMinkov:mainfrom
Draft
Implemented Trim of empty spaces of queryString search#58PetarNeshkov wants to merge 2 commits intoMinkov:mainfrom
PetarNeshkov wants to merge 2 commits intoMinkov:mainfrom
Conversation
gogo4ds
requested changes
Nov 24, 2023
| else if (int.TryParse(idAsString, out var entityIdInt)) | ||
| { | ||
| id = entityIdInt; | ||
| id = entityIdInt.ToString().Trim(); |
Collaborator
There was a problem hiding this comment.
How can entityIdInt have empty spaces? Isn't supposed to be integer?
Contributor
Author
There was a problem hiding this comment.
I added it for an additional check. Removing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/SoftUni-Internal/exam-systems-issues/issues/806#event-10817148661
Explanation: When we filter some properties and add additional spaces, the grid returns an empty table. In order to prevent this, we implement trim of searched input.