Fabric 1.20.4 update #127

tticehurst · 2023-12-15T15:23:39Z

Compiled well on Fabric. Disabled forge as it would not compile.
Attempted troubleshoot but only have limited experience with forge over fabric.

Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>

…t.java Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>

tticehurst · 2023-12-16T13:11:36Z

Added changes suggested

tticehurst · 2023-12-16T15:08:35Z

Even with that fix, there's still another issue with the forge build. It fails in the dev env because of how architectury plugin splits the build into two mods. Upstream have a fix, but I haven't looked into it yet. It may work in production though (if so, forge could be re-enabled).

Can confirm it works in production

tticehurst · 2023-12-16T15:41:41Z

Added nitpicks

MattSturgeon

Great. Personally, I'd squash all commits into one & then force-push, but idk how picky @hashalite is about keeping commit history clean.

I might post some build artifacts on #125 as idk how long it'll take for @hashalite to see/merge this...

tticehurst · 2023-12-16T15:46:22Z

Will leave how the commits are for now until hashalite responds then will go from there, easier to squash than unsquash

MattSturgeon · 2023-12-16T16:15:02Z

Here's a prod fabric build: freecam-fabric-1.2.1.1-1.20.4.zip

For some reason the forge build is failing in prod with Could not find net/minecraft/client/Minecraft.class in classloader. Looks like the build isn't being remapped to searge mappings correctly? freecam-forge-1.2.1.1-1.20.4.zip.

I haven't got time to look into this right now, it may or may not be 1.20.4 specific (could be a bug with #118)...

Launcher: standard

Java Arguments:
[-Xms2048m, -Xmx8064m, -Duser.language=en]


Minecraft process ID: 839


Checking: MERGED_MAPPINGS
Checking: MAPPINGS
Checking: MOJMAPS
Checking: PATCHED
Checking: MC_SRG
2023-12-16 16:06:20,459 main WARN Advanced terminal features are not available in this environment
[16:06:20] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, Bot_1, --version, 1.20.4, --gameDir, /home/matt/.var/app/org.prismlauncher.PrismLauncher/data/PrismLauncher/instances/freecam 1.20.4 forge test/.minecraft, --assetsDir, /home/matt/.var/app/org.prismlauncher.PrismLauncher/data/PrismLauncher/assets, --assetIndex, 12, --uuid, <PROFILE ID>, --accessToken, **********, --userType, offline, --versionType, release, --launchTarget, forge_client, --fml.forgeGroup, net.minecraftforge, --fml.forgeVersion, 49.0.9, --fml.mcVersion, 1.20.4, --width, 854, --height, 480]
[16:06:20] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: JVM identified as Flathub OpenJDK 64-Bit Server VM 17.0.9+7
[16:06:20] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 10.1.2 starting: java version 17.0.9 by Flathub; OS Linux arch amd64 version 6.6.3-1-default
[16:06:20] [main/INFO] [ne.mi.fm.lo.ImmediateWindowHandler/]: Loading ImmediateWindowProvider fmlearlywindow
[16:06:20] [main/INFO] [EARLYDISPLAY/]: Trying GL version 4.6
[16:06:20] [main/INFO] [EARLYDISPLAY/]: Requested GL version 4.6 got version 4.6
[16:06:20] [EarlyDisplay/INFO] [EARLYDISPLAY/]: GL info: AMD Radeon RX 5700 XT (navi10, LLVM 16.0.6, DRM 3.54, 6.6.3-1-default) GL version 4.6 (Core Profile) Mesa 23.2.1 (git-49a47f187e), AMD
[16:06:20] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=jar:file:///home/matt/.var/app/org.prismlauncher.PrismLauncher/data/PrismLauncher/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar!/ Service=ModLauncher Env=CLIENT
Exception caught from launcher
java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:66)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Caused by: java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at net.minecraftforge.bootstrap.Bootstrap.start(Bootstrap.java:48)
	at net.minecraftforge.bootstrap.ForgeBootstrap.main(ForgeBootstrap.java:18)
	... 8 more
Caused by: java.lang.IllegalStateException: Could not find net/minecraft/client/Minecraft.class in classloader SecureModuleClassLoader[SECURE-BOOTSTRAP]@102065302
	at SECURE-BOOTSTRAP/net.minecraftforge.fmlloader@1.20.4-49.0.9/net.minecraftforge.fml.loading.targets.CommonLaunchHandler.getPathFromResource(CommonLaunchHandler.java:98)
	at SECURE-BOOTSTRAP/net.minecraftforge.fmlloader@1.20.4-49.0.9/net.minecraftforge.fml.loading.targets.ForgeProdLaunchHandler$Client.getMinecraftPaths(ForgeProdLaunchHandler.java:28)
	at SECURE-BOOTSTRAP/net.minecraftforge.fmlloader@1.20.4-49.0.9/net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator.scanMods(MinecraftLocator.java:24)
	at SECURE-BOOTSTRAP/net.minecraftforge.fmlloader@1.20.4-49.0.9/net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer.discoverMods(ModDiscoverer.java:80)
	at SECURE-BOOTSTRAP/net.minecraftforge.fmlloader@1.20.4-49.0.9/net.minecraftforge.fml.loading.FMLLoader.beginModScan(FMLLoader.java:154)
	at SECURE-BOOTSTRAP/net.minecraftforge.fmlloader@1.20.4-49.0.9/net.minecraftforge.fml.loading.FMLServiceProvider.beginScanning(FMLServiceProvider.java:58)
	at SECURE-BOOTSTRAP/cpw.mods.modlauncher@10.1.2/cpw.mods.modlauncher.TransformationServiceDecorator.runScan(TransformationServiceDecorator.java:98)
	at SECURE-BOOTSTRAP/cpw.mods.modlauncher@10.1.2/cpw.mods.modlauncher.TransformationServicesHandler.lambda$runScanningTransformationServices$7(TransformationServicesHandler.java:96)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.HashMap$ValueSpliterator.forEachRemaining(HashMap.java:1779)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:575)
	at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:616)
	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:622)
	at java.base/java.util.stream.ReferencePipeline.toList(ReferencePipeline.java:627)
	at SECURE-BOOTSTRAP/cpw.mods.modlauncher@10.1.2/cpw.mods.modlauncher.TransformationServicesHandler.runScanningTransformationServices(TransformationServicesHandler.java:98)
	at SECURE-BOOTSTRAP/cpw.mods.modlauncher@10.1.2/cpw.mods.modlauncher.TransformationServicesHandler.initializeTransformationServices(TransformationServicesHandler.java:49)
	at SECURE-BOOTSTRAP/cpw.mods.modlauncher@10.1.2/cpw.mods.modlauncher.Launcher.run(Launcher.java:86)
	at SECURE-BOOTSTRAP/cpw.mods.modlauncher@10.1.2/cpw.mods.modlauncher.Launcher.main(Launcher.java:73)
	at SECURE-BOOTSTRAP/cpw.mods.modlauncher@10.1.2/cpw.mods.modlauncher.BootstrapEntry.main(BootstrapEntry.java:17)
	at net.minecraftforge.bootstrap@2.0.0/net.minecraftforge.bootstrap.Bootstrap.moduleMain(Bootstrap.java:97)
	... 14 more
Exiting with ERROR
Process exited with code 2.

The only changes I've made are to the archive base: MattSturgeon@725ee5d

tticehurst · 2023-12-16T16:30:49Z

hmm I managed to load up mc with the forge build and it all worked fine

MattSturgeon · 2023-12-16T17:20:58Z

Just installed the official launcher and tested again. Works fine there.

I wasn't hitting an issue with our build, rather LexForge has broken support for unofficial launchers: MinecraftForge/MinecraftForge#9815
EDIT: looks like a different error actually, but still only affects non-official launcher 🤔

hashalite · 2023-12-19T07:37:57Z

Hello, apologies for the delay in getting back to you. I have been quite busy with exams over the past couple weeks. Thanks for taking the time to update the mod! Don't worry about cleaning up the commit history, I'm not too picky about that. I just want to confirm the issue with the forge build is not on our end before merging. Has anyone had time to look into it further?

MattSturgeon · 2023-12-19T14:57:08Z

Hello, apologies for the delay in getting back to you. I have been quite busy with exams over the past couple weeks.

No worries, hopefully they went well 🤞

I just want to confirm the issue with the forge build is not on our end before merging. Has anyone had time to look into it further?

I've not looked into it much yet. My understanding is there's two separate issues; one effecting the dev env and the other affecting unofficial launchers.

I suspect the dev env will be solved by an architectury-loom update or some workaround discussed in they're discord. This shouldn't block doing a release.

I believe the unofficial launcher issue has nothing to do with our mod, and (if it's not fixed by launchers yet) would be reproducible even without any mods installed.

Again, I haven't confirmed that yet.

tticehurst · 2023-12-19T17:07:54Z

Tried installing forge on multimc, just met with an error when attempting to lanch even without any mods. Seems to be a forge related issue rather than a mod one

MattSturgeon · 2023-12-24T02:54:15Z

@hashalite It'd be great to get this merged and/or get a 1.20.4 release out before xmas 😀 🎄

I know I've created a bunch of merge conflicts in other PRs. Let me know if you'd like me to put a branch together with the current conflicts resolved.

hashalite · 2023-12-24T03:23:41Z

@hashalite It'd be great to get this merged and/or get a 1.20.4 release out before xmas 😀 🎄

Yup! That's my goal

I know I've created a bunch of merge conflicts in other PRs. Let me know if you'd like me to put a branch together with the current conflicts resolved.

If it isn't too much trouble, this would be very helpful

hashalite · 2023-12-24T04:56:54Z

If it isn't too much trouble, this would be very helpful

Never mind, it was just a couple of changes

hashalite · 2023-12-24T04:57:58Z

Thanks again you all!

tticehurst added 4 commits December 15, 2023 14:43

update to 1.20.4

08ab777

fabric 1.20.4 update

b3028da

1.20.4 update

d0aae51

disabled forge

e80b3a9

tticehurst mentioned this pull request Dec 15, 2023

Update to support 1.20.4 #125

Closed

This comment was marked as resolved.

Sign in to view

tticehurst and others added 4 commits December 16, 2023 13:10

bump modmenu and cloth

56b1020

Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>

Update gradle.properties

20a34fd

Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>

add comment

e73b165

Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>

Update common/src/main/java/net/xolt/freecam/config/CollisionWhitelis…

151a047

…t.java Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>

tticehurst added 3 commits December 16, 2023 14:59

Reverted mod version change - added yarn_mappings_patch

8b93199

added include back for forge

13b20f0

Added mappings fix

da56913

This comment was marked as resolved.

Sign in to view

tticehurst added 2 commits December 16, 2023 15:40

bump loom to 1.4-SNAPSHOT

8549ab1

moved yarn_mappings_patch under yarn_mappings

1aa54fc

MattSturgeon approved these changes Dec 16, 2023

View reviewed changes

Merge branch 'main' into main

9b6843b

hashalite merged commit 4f6d1e1 into MinecraftFreecam:main Dec 24, 2023

Fabric 1.20.4 update #127

Fabric 1.20.4 update #127

Uh oh!

Conversation

tticehurst commented Dec 15, 2023

Uh oh!

This comment was marked as resolved.

Uh oh!

tticehurst commented Dec 16, 2023

Uh oh!

tticehurst commented Dec 16, 2023

Uh oh!

This comment was marked as resolved.

Uh oh!

tticehurst commented Dec 16, 2023

Uh oh!

MattSturgeon left a comment

Choose a reason for hiding this comment

Uh oh!

tticehurst commented Dec 16, 2023

Uh oh!

MattSturgeon commented Dec 16, 2023

Uh oh!

tticehurst commented Dec 16, 2023

Uh oh!

MattSturgeon commented Dec 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hashalite commented Dec 19, 2023

Uh oh!

MattSturgeon commented Dec 19, 2023

Uh oh!

tticehurst commented Dec 19, 2023

Uh oh!

MattSturgeon commented Dec 24, 2023

Uh oh!

hashalite commented Dec 24, 2023

Uh oh!

hashalite commented Dec 24, 2023

Uh oh!

hashalite commented Dec 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MattSturgeon commented Dec 16, 2023 •

edited

Loading