Add to calendar link #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2017 00:20
MilanLund
requested changes
Sep 28, 2017
Owner
MilanLund
left a comment
MilanLund
left a comment
There was a problem hiding this comment.
Thanks for the pull request. I did a quick review and I noticed that your implementation is relevant for a specific time zone (see the ctz=America%2FChicago parameter). I think it should work worldwide. Also, I would appreciate some comments on the changes. I don't understand why you do .replace('05:00','') on line 151. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds URL and adds 'Add to your Calendar!' HTML Link in format. Works on mobile directly into GCal app as well.