Skip to content

Conversation

@Mathbl
Copy link

@Mathbl Mathbl commented Jan 29, 2016

This is working for my use case. I'm able to set
<item name="android:textSize">@dimen/font_size_toolbar</item> where font_size_toolbar is 20sp.

I was hesitating to make a variable for DEFAULT_TEXT_SIZE in MaterialSearchView.java
e.g.:
public static final int DEFAULT_TEXT_SIZE = 15;
then we can do:
setTextSize(a.getDimensionPixelSize(R.styleable.MaterialSearchView_android_textSize, DEFAULT_TEXT_SIZE));

But tbh, i'm not sure if it's needed.

@MiguelCatalan
Copy link
Owner

Awesome! I will check it today and merge it ASAP!
Thanks for the PR

@ffgiraldez
Copy link

rather that textSize, use TextAppearance to full style EditText

@MiguelCatalan
Copy link
Owner

Sorry for the delay, I've been full of shit for the last few months. In the next days I will check all the PRs and give you an answer.

@kyhule
Copy link

kyhule commented Mar 23, 2017

@MiguelCatalan is this ever going to get merged?

@wisnukurniawan
Copy link

hello @MiguelCatalan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants