Develop 4.3 #83
Merged
Develop 4.3 #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elements explicitly
…and ensure proper push of sorted en.xml
…n and improve commit logic
…and improve clarity
… sorting of en.xml
…nused translation keys
…ring checker workflow
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
WARNING: Unused translation keys detected
UNUSED: PLG_INVENTORY_MANAGER_CONFIGURATION
UNUSED: PLG_INVENTORY_MANAGER_EXPORT_AND_FILTER
UNUSED: PLG_INVENTORY_MANAGER_IMPORT_ITEMS
UNUSED: PLG_INVENTORY_MANAGER_IMPORT_PROGRESS
UNUSED: PLG_INVENTORY_MANAGER_ITEMNAME
UNUSED: PLG_INVENTORY_MANAGER_ITEM_CREATE_DESC
UNUSED: PLG_INVENTORY_MANAGER_ITEM_PRINT
UNUSED: PLG_INVENTORY_MANAGER_NEW
UNUSED: PLG_INVENTORY_MANAGER_NUMBER_OF_ITEMS
UNUSED: PLG_INVENTORY_MANAGER_SPECIAL_CASE_CURUSER_OR_ADMIN
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE_DESC
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE_ERROR
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE_NO_ASSIGN
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE_PREVIEW
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE_SAVED
Please consider removing or using these keys.
There was a problem hiding this comment.
WARNING: Unused translation keys detected
UNUSED: PLG_INVENTORY_MANAGER_CONFIGURATION
UNUSED: PLG_INVENTORY_MANAGER_EXPORT_AND_FILTER
UNUSED: PLG_INVENTORY_MANAGER_IMPORT_ITEMS
UNUSED: PLG_INVENTORY_MANAGER_IMPORT_PROGRESS
UNUSED: PLG_INVENTORY_MANAGER_ITEMNAME
UNUSED: PLG_INVENTORY_MANAGER_ITEM_CREATE_DESC
UNUSED: PLG_INVENTORY_MANAGER_ITEM_PRINT
UNUSED: PLG_INVENTORY_MANAGER_NEW
UNUSED: PLG_INVENTORY_MANAGER_NUMBER_OF_ITEMS
UNUSED: PLG_INVENTORY_MANAGER_SPECIAL_CASE_CURUSER_OR_ADMIN
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE_DESC
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE_ERROR
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE_NO_ASSIGN
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE_PREVIEW
UNUSED: PLG_INVENTORY_MANAGER_SYNCHRONIZE_SAVED
Please consider removing or using these keys.
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances translation management by streamlining the XML files for various languages and introducing new scripts and workflows for sorting translation keys and checking for unused ones.
- Removed several unused or duplicate translation keys from language files.
- Introduced new GitHub workflows for sorting en.xml and checking for unused translation strings.
- Updated the XML sorting script to use lxml in order to preserve comments and formatting.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| languages/fr.xml, languages/de.xml, de-DE.xml, en.xml | Removed obsolete keys and ensured consistency across languages. |
| .github/workflows/sort-en-xml.yml | Added a new step to install lxml and improved commit logic. |
| .github/workflows/check-unused-strings.yml | Created a workflow to run a new script for detecting unused keys. |
| .github/scripts/sort_en_xml.py | Replaced the standard XML library with lxml for better comment handling and sorting. |
| .github/scripts/check_unused_strings.py | Added a script to detect unused translation keys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to streamline translation management and ensure consistency in the
languages/en.xmlfile. It includes new scripts for detecting unused translation keys, improving sorting functionality, and automating these processes in GitHub workflows.