Skip to content

fix : temporary disable onclick attribute other card #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myanpetra99 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix : temporary disable onclick attribute other card #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
895ead3
fix : temporary disable onclick attribute from all cards when unmatched
myanpetra99 Sep 18, 2023
0877fd1
Merge pull request #1 from myanpetra99/myanpetra99-patch-1
myanpetra99 Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ function checkMatchCard(item) {

// function to rmove class open and show from cards [first and second card]
function clearSelectedCards() {
let allCards = document.querySelectorAll('.card:not(.match)');
allCards.forEach(card => card.removeAttribute('onclick'));

setTimeout(() => {
if (firstCard) {
firstCard.classList.remove('open');
Expand All @@ -158,6 +161,8 @@ function clearSelectedCards() {
secondCard.classList.remove('show');
secondCard = null;
}

allCards.forEach(card => card.setAttribute('onclick', 'startGame(this)'));
}, 1000);
}

Expand Down Expand Up @@ -258,4 +263,4 @@ playAgain();
* + if the cards do not match, remove the cards from the list and hide the card's symbol (put this functionality in another function that you call from this one)[Done]
* + increment the move counter and display it on the page (put this functionality in another function that you call from this one)[Done]
* + if all cards have matched, display a message with the final score (put this functionality in another function that you call from this one)[Done]
*/
*/