Add configurable pinouts #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBell
reviewed
Feb 19, 2025
Owner
MichaelBell
left a comment
MichaelBell
left a comment
There was a problem hiding this comment.
Looks good to me - thank you! Two super tiny comments
README.md
Outdated
| function. | ||
| This pinout consists of 4 numbers giving the *positive* pin in each differential pair, in the order CK, D0, D1, D2, D3, using GPIO numbering. | ||
| The default pinout is written `{13, 15, 17, 19}`. | ||
| Only pin numbers from 12 to 20 are valid, as other pins are not connected to the HSTX peripheral. |
drivers/dvhstx/dvhstx.cpp
Outdated
| } | ||
| hstx_ctrl_hw->bit[bit ] = lane_data_sel_bits; | ||
| hstx_ctrl_hw->bit[bit ^ 1] = lane_data_sel_bits | HSTX_CTRL_BIT0_INV_BITS; | ||
| } |
Contributor
Author
|
Review comments addressed, thanks. |
Contributor
Author
|
I don't understand the CI failure, let me know if there's something I need to do there. |
Owner
|
Merged - thank you. The CI failure is just because I haven't updated this repo in far too long - I think Gadgetoid might have deleted a branch it is using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from Adafruit_dvhstx.
I tested this on a prototype Adafruit FruitJam and both before and after my changes the program wouldn't start "normally" (from power on or pressing reset) but would start with a gdb "run" command. Weird, and something to diagnose on my end.